Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrades OCI to 2.41.0 on helidon-2.x #4812

Merged
merged 5 commits into from
Aug 31, 2022
Merged

Upgrades OCI to 2.41.0 on helidon-2.x #4812

merged 5 commits into from
Aug 31, 2022

Conversation

ljnelson
Copy link
Member

Signed-off-by: Laird Nelson [email protected]

@ljnelson ljnelson added P3 2.x Issues for 2.x version branch OCI labels Aug 30, 2022
@ljnelson ljnelson self-assigned this Aug 30, 2022
@ljnelson
Copy link
Member Author

This PR as it exists cannot be merged; there are test failures:

org.opentest4j.AssertionFailedError: Timed out after 10 sec. waiting for testMetricCount
	at org.junit.jupiter.api.AssertionUtils.fail(AssertionUtils.java:39)
	at org.junit.jupiter.api.Assertions.fail(Assertions.java:117)
	at io.helidon.integrations.oci.metrics.OciMetricsSupportTest.validateMetricCount(OciMetricsSupportTest.java:271)
	at io.helidon.integrations.oci.metrics.OciMetricsSupportTest.validateMetricCount(OciMetricsSupportTest.java:260)
	at io.helidon.integrations.oci.metrics.OciMetricsSupportTest.testMetricScope(OciMetricsSupportTest.java:158)

@ljnelson
Copy link
Member Author

@barchetta Please look at dependencies/pom.xml. I've inlined the contents of the OCI BOM at the bottom of the file. I had to comment out oci-objectstorage's entry while so doing because we already dependency manage it separately above. Lastly, I've left in all the redundant <optional>false</optional> elements because copying and pasting these entries is burdensome enough without having to edit them severely with every subsequent upgrade.

@ljnelson ljnelson mentioned this pull request Aug 30, 2022
Closed
@ljnelson
Copy link
Member Author

Test failures are present on my local machine prior to this PR, so I'll go ahead and undraft it.

@ljnelson ljnelson marked this pull request as ready for review August 30, 2022 18:16
@ljnelson
Squashable commit; addressing a couple of issues in OciMetricsSupport…
54d79a9 
…Test; intermittent failures still present

Signed-off-by: Laird Nelson <[email protected]>
@ljnelson ljnelson mentioned this pull request Aug 30, 2022
Closed
@ljnelson ljnelson merged commit e300ae8 into helidon-io:helidon-2.x Aug 31, 2022
@ljnelson ljnelson deleted the upgrade-oci-to-2.41.0-helidon-2.x branch August 31, 2022 00:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@barchetta barchetta barchetta approved these changes

@romain-grecourt romain-grecourt Awaiting requested review from romain-grecourt

@klustria klustria Awaiting requested review from klustria

Assignees

@ljnelson ljnelson

Labels
2.x Issues for 2.x version branch OCI P3
Projects
Backlog
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ljnelson @barchetta