Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Universal OCI CDI extension #3961

Merged
merged 94 commits into from
Mar 21, 2022
Merged

Universal OCI CDI extension #3961

merged 94 commits into from
Mar 21, 2022

Conversation

ljnelson
Copy link
Member

This PR creates a portable extension that provides injection support for any service interface, service client, service client builder, asynchronous service interface, asynchronous service client or asynchronous service client builder in the Oracle Cloud Infrastructure Java SDK portfolio of services.

Other changes in the PR are related:

  • The integrations/cdi/oci-objectstorage-cdi extension is deprecated
  • The existing example project that uses the deprecated extension is updated to use this new one
  • The example now also runs under native image
  • The existing documentation has been somewhat cursorily updated
  • The OCI version has been updated to 2.19.0
  • A package-list has been installed so that javadocs cross-link

ljnelson added 30 commits March 3, 2022 20:21
@ljnelson
Experimental. A single CDI portable extension that allows you to inje…
68484d0 
…ct any OCI client you want.

Signed-off-by: Laird Nelson <[email protected]>
@ljnelson
Squashable commit; introduces lots of configurability for ADPs
16fe027 
Signed-off-by: Laird Nelson <[email protected]>
@ljnelson
Squashable commit; refining
30c0c6e 
Signed-off-by: Laird Nelson <[email protected]>
@ljnelson
Squashable commit; refining
0d86cc4 
Signed-off-by: Laird Nelson <[email protected]>
@ljnelson
Squashable commit; refining
60d09f8 
Signed-off-by: Laird Nelson <[email protected]>
@ljnelson
Squashable commit; refining
5fe131e 
Signed-off-by: Laird Nelson <[email protected]>
@ljnelson
Squashable commit; refining
ed8488f 
Signed-off-by: Laird Nelson <[email protected]>
@ljnelson
Squashable commit; refining
61f9623 
Signed-off-by: Laird Nelson <[email protected]>
@ljnelson
Squashable commit; refining
21cd73c 
Signed-off-by: Laird Nelson <[email protected]>
@ljnelson
Squashable commit; refining
e8c6090 
Signed-off-by: Laird Nelson <[email protected]>
@ljnelson
Squashable commit; refining
ddbe2ca 
Signed-off-by: Laird Nelson <[email protected]>
@ljnelson
Squashable commit; refining
71e4f45 
Signed-off-by: Laird Nelson <[email protected]>
@ljnelson
Squashable commit; refining
79a0ca5 
Signed-off-by: Laird Nelson <[email protected]>
@ljnelson
Squashable commit; refining
d3f2943 
Signed-off-by: Laird Nelson <[email protected]>
@ljnelson
Squashable commit; refining
4234277 
Signed-off-by: Laird Nelson <[email protected]>
@ljnelson
Squashable commit; refining
d5c8540 
Signed-off-by: Laird Nelson <[email protected]>
@ljnelson
Squashable commit; refining
726ee11 
Signed-off-by: Laird Nelson <[email protected]>
@ljnelson
Squashable commit; refining
42714fd 
Signed-off-by: Laird Nelson <[email protected]>
@ljnelson
Squashable commit; refining
88d43cd 
Signed-off-by: Laird Nelson <[email protected]>
@ljnelson
Squashable commit; refining
bc99ac3 
Signed-off-by: Laird Nelson <[email protected]>
@ljnelson
Squashable commit; added MonitoringObservers.java
8400ab2 
Signed-off-by: Laird Nelson <[email protected]>
@ljnelson
Squashable commit; realized client customization can be done on Clien…
f82f243 
…tBuilderBase so no need for conditional monitoring loading etc.

Signed-off-by: Laird Nelson <[email protected]>
@ljnelson
Squashable commit; refining
79a0017 
Signed-off-by: Laird Nelson <[email protected]>
@ljnelson
Squashable commit; refining
664390a 
Signed-off-by: Laird Nelson <[email protected]>
@ljnelson
Squashable commit; refining
2216c2f 
Signed-off-by: Laird Nelson <[email protected]>
@ljnelson
Squashable commit; refining
462a6c4 
Signed-off-by: Laird Nelson <[email protected]>
@ljnelson
Squashable commit; refining
add592a 
Signed-off-by: Laird Nelson <[email protected]>
@ljnelson
Squashable commit; refining
ceaa490 
Signed-off-by: Laird Nelson <[email protected]>
@ljnelson
Squashable commit; massive refactoring/simplification; method cleanup…
45ab524 
… coming

Signed-off-by: Laird Nelson <[email protected]>
@ljnelson
Squashable commit; refining
9ee82bd 
Signed-off-by: Laird Nelson <[email protected]>
@klustria klustria self-requested a review March 15, 2022 22:31
klustria
klustria previously approved these changes Mar 16, 2022
View reviewed changes
Copy link
Member

@klustria klustria left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fine from my point of view and have already tested to be working. Would be great if other folks from the team review this as well.

@trentjeff trentjeff self-requested a review March 16, 2022 14:40
ljamen
ljamen reviewed Mar 16, 2022
View reviewed changes
Copy link
Contributor

@ljamen ljamen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I will review the class javadoc file separately.

trentjeff
trentjeff previously approved these changes Mar 16, 2022
View reviewed changes
Copy link
Member

@trentjeff trentjeff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great to me @ljnelson. Left one comment for consideration.

@barchetta barchetta added this to the 2.4.3 milestone Mar 17, 2022
@ljnelson ljnelson mentioned this pull request Mar 18, 2022
Closed
@ljnelson ljnelson dismissed stale reviews from trentjeff and klustria via 2635dd3 March 18, 2022 20:48
klustria
klustria approved these changes Mar 18, 2022
View reviewed changes
Copy link
Member

@klustria klustria left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Viewed the latest changes and looks good to me!

danielkec
danielkec reviewed Mar 19, 2022
View reviewed changes
integrations/cdi/oci/src/main/java/io/helidon/integrations/cdi/oci/OciExtension.java


private TypeAndQualifiers(final Type type, final Annotation[] qualifiers) {
super();
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why? 🤔

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why the super() call? I like being explicit, I guess…

@trentjeff trentjeff self-requested a review March 21, 2022 14:39
@barchetta barchetta mentioned this pull request Mar 21, 2022
Closed
@ljnelson ljnelson merged commit 8789082 into helidon-io:helidon-2.x Mar 21, 2022
@ljnelson ljnelson deleted the universal-oci-cdi branch March 21, 2022 21:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@danielkec danielkec danielkec left review comments

@ljamen ljamen ljamen left review comments

@barchetta barchetta barchetta approved these changes

@tomas-langer tomas-langer tomas-langer approved these changes

@klustria klustria klustria approved these changes

@trentjeff trentjeff trentjeff approved these changes

@arjav-desai arjav-desai Awaiting requested review from arjav-desai

@tjquinno tjquinno Awaiting requested review from tjquinno

Assignees

@ljnelson ljnelson

Labels
None yet
Projects
None yet
Milestone
2.5.0
Development

Successfully merging this pull request may close these issues.
7 participants
@ljnelson @danielkec @barchetta @tomas-langer @ljamen @klustria @trentjeff