Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix serviceName usage for OCI ATP integration #3711

Merged
merged 10 commits into from
Dec 8, 2021

Conversation

arjav-desai
Copy link
Member

arjav-desai and others added 9 commits November 26, 2021 18:19
…icsSettings (helidon-io#3659)

* Add test for overall disabled metrics

* Defer creating the RegistryFactory INSTANCE until first actual retrieval so as to use the latest-provided MetricsSettings

* Reorder some code so the metrics CDI initialized the RegistryFactory with the correct MetricsSettings before the producer 'clearApplicationRegistry' method is invoked
…access to RegistryFactory (helidon-io#3663)

* Set initial MetricsSettings for creating RegistryFactory from config; still can be changed by later calls to getInstance(MetricsSettings)

* Need to support no-op Gauge after all

* Defer use of RegistryFactory as long as possible for executor metrics

* Reorder some steps in MP metrics service initialization

* In MP fault tolerance, defer access to RegistryFactory

* In Jaeger metrics defer access to RegistryFactory

* In DB client defer access to RegistryFactory

* In grpc defer access to RegistryFactory

* Add MP/metrics test for disabled metrics
* Execute writes on event-loop thread only

Signed-off-by: Daniel Kec <[email protected]>
@arjav-desai arjav-desai added this to the 2.4.1 milestone Dec 8, 2021
@arjav-desai arjav-desai requested a review from ljnelson December 8, 2021 15:09
@arjav-desai arjav-desai self-assigned this Dec 8, 2021
@arjav-desai arjav-desai merged commit 15e8add into helidon-io:helidon-2.x Dec 8, 2021
@arjav-desai arjav-desai deleted the helidon-3648 branch June 29, 2022 18:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants