-
Notifications
You must be signed in to change notification settings - Fork 568
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix serviceName usage for OCI ATP integration #3711
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…icsSettings (helidon-io#3659) * Add test for overall disabled metrics * Defer creating the RegistryFactory INSTANCE until first actual retrieval so as to use the latest-provided MetricsSettings * Reorder some code so the metrics CDI initialized the RegistryFactory with the correct MetricsSettings before the producer 'clearApplicationRegistry' method is invoked
…access to RegistryFactory (helidon-io#3663) * Set initial MetricsSettings for creating RegistryFactory from config; still can be changed by later calls to getInstance(MetricsSettings) * Need to support no-op Gauge after all * Defer use of RegistryFactory as long as possible for executor metrics * Reorder some steps in MP metrics service initialization * In MP fault tolerance, defer access to RegistryFactory * In Jaeger metrics defer access to RegistryFactory * In DB client defer access to RegistryFactory * In grpc defer access to RegistryFactory * Add MP/metrics test for disabled metrics
* Execute writes on event-loop thread only Signed-off-by: Daniel Kec <[email protected]>
Signed-off-by: Daniel Kec <[email protected]>
ljnelson
reviewed
Dec 8, 2021
...p/src/main/java/io/helidon/integrations/datasource/ucp/cdi/UCPBackedDataSourceExtension.java
Show resolved
Hide resolved
ljnelson
approved these changes
Dec 8, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#3648