Request correlation #3426
Merged
Request correlation #3426
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tomas-langer
force-pushed
the
request-correlation
branch
2 times, most recently
from
d06dbf8 to
109e6b6
Compare
barchetta
requested changes
Sep 21, 2021
webserver/webserver/src/main/java/io/helidon/webserver/ForwardingHandler.java
Outdated
Show resolved
Hide resolved
webserver/webserver/src/main/java/io/helidon/webserver/BareResponseImpl.java
Show resolved
Hide resolved
tomas-langer
force-pushed
the
request-correlation
branch
from
bb4d4a8 to
adfdab7
Compare
Using context-id and adding it to MDC. Using the same channel ID as Netty uses in its logs. Guarding log statements to prevent capturing lambdas. Signed-off-by: Tomas Langer <[email protected]>
Signed-off-by: Tomas Langer <[email protected]>
tomas-langer
force-pushed
the
request-correlation
branch
from
b087d9d to
a2789ed
Compare
barchetta
approved these changes
Sep 22, 2021
Verdent
approved these changes
Sep 22, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added better correlation to webserver requests for troubleshooting purposes.
io.helidon.common.Context)io.helidon.scope-idinForwardingHandler)Now it is much easier to map client requests (such as from
curldebug or TCP dump) to web server requests and to their processing in Helidon.Adds
helidon-logging-commondependency to webserver. To use this feature, one of the logging modules must be used (such ashelidon-logging-jul) and configuration modified (see examples for logging).