Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix micrometer test #3234

Merged
merged 9 commits into from
Aug 3, 2021
Merged

Fix micrometer test #3234

merged 9 commits into from
Aug 3, 2021

Conversation

tjquinno
Copy link
Member

Resolves #3212

tomas-langer and others added 7 commits July 22, 2021 14:26
@tomas-langer
Example reactive code usage update.
cd16a30 
Signed-off-by: Tomas Langer <[email protected]>
@tomas-langer
Copyright fix
11afcec 
Signed-off-by: Tomas Langer <[email protected]>
@spericas @tjquinno
Explicitly destroy bean instance obtained from CDI object that is not…
f08bf2d 
… in a normal scope. Not manually destroying these instances resulted in the context' map monotonically growing in size as described in Issue #3199. (#3214)

Signed-off-by: Santiago Pericasgeertsen <[email protected]>
@spericas @tjquinno
Modified logic to not close scopes before switching threads as this i…
c8a3cb9 
…s problematic when running async operations (such as in auth) and continuing work on the request thread. Instead, provide our own implementation of ScopeManager that allows closing a scope from any thread, not just the one that created it. Some new tests. (#3207)

Signed-off-by: Santiago Pericasgeertsen <[email protected]>
@tjquinno
Fix test to check for correct values of metrics
f9a6bd7
@tjquinno
Fix test to check for correct values of metrics
2044b5a
@tjquinno
Concurrent changes
c2b4024
@tjquinno tjquinno self-assigned this Jul 29, 2021
spericas
spericas previously approved these changes Aug 3, 2021
View reviewed changes
Copy link
Member

@spericas spericas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

My only comment is that startup 2 seconds and shutdown 10 seconds seems a bit odd. On a really slow pipeline, I would think 2 seconds may be a bit tight. That was there before, though.

@tjquinno tjquinno merged commit 011f6f0 into helidon-io:master Aug 3, 2021
@tjquinno tjquinno deleted the fix-micrometer-test branch August 3, 2021 21:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@spericas spericas spericas approved these changes

@tomas-langer tomas-langer Awaiting requested review from tomas-langer

Assignees

@tjquinno tjquinno

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Micrometer test in examples fails
3 participants
@tjquinno @spericas @tomas-langer