HTTP Signature fix to work according to specification. #2884
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Verdent
approved these changes
Mar 26, 2021
paulparkinson
pushed a commit
that referenced
this pull request
Mar 29, 2021
aseovic
pushed a commit
to aseovic/helidon
that referenced
this pull request
Apr 26, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
During integration with OCI I have discovered that our implementation of HTTP Signatures adds an unexpected end of line to the end of the signed text.
This fix is backward compatible, but allows configuration change to use "spec-compatible" version of the provider/outbound target.
The configuration key is
backward-compatible-eol, defaults totrue. Configuring it tofalsewill make it behave as the spec requires.This should be changed in 3.0.0
Also added support to use a custom
TokenHandlerto put the signature in any header.