-
Notifications
You must be signed in to change notification settings - Fork 567
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Download Kafka binaries from archive if not present on mirror #2768
Download Kafka binaries from archive if not present on mirror #2768
Conversation
Signed-off-by: Daniel Kec <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we should always use an explicit version of dependencies, even in examples.
You can add this to README.md
as a way to get the latest version.
We should never have code that can use unknown versions.
Signed-off-by: Daniel Kec <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
* Download Kafka binaries from archive if not available on mirror Signed-off-by: Daniel Kec <[email protected]>
…n-io#2768) * Download Kafka binaries from archive if not available on mirror Signed-off-by: Daniel Kec <[email protected]>
Only few latest versions of Kafka binaries are accessible over Apache mirror, download the latest one to keep the docker file from getting obsolete.
Signed-off-by: Daniel Kec [email protected]