Faster license filtering #2749
Merged
Faster license filtering #2749
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
danielkec
force-pushed
the
faster-licenses
branch
from
fe87348 to
8401509
Compare
Signed-off-by: Daniel Kec <[email protected]>
|
I am having the same issue as @danielkec |
barchetta
approved these changes
Feb 11, 2021
tomas-langer
approved these changes
Feb 11, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ubuntu linux build with skipped tests
mvn clean install -DskipTests:Before: Total time: 03:53 min
After: Total time: 01:49 min
Windows 10 build with skipped tests in WSL
mvn clean install -DskipTests:Before: Total time: 01:24 h
After: Total time: 03:10 min
Looks like copy-resources plugin is scanning all directories recursively before applying includes. That means iterating over 50000 files in every module (~220)
Signed-off-by: Daniel Kec [email protected]