Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix NPE on error in tx #2286 #2437

Merged
merged 4 commits into from
Oct 14, 2020
Merged

Fix NPE on error in tx #2286 #2437

merged 4 commits into from
Oct 14, 2020

Conversation

danielkec
Copy link
Contributor

@danielkec danielkec commented Oct 12, 2020 •
edited
Loading

Fixes #2286

@danielkec
Fix NPE on error in tx helidon-io#2286
60fe875 
Signed-off-by: Daniel Kec <[email protected]>
@danielkec
Switch to Single
ea24aed 
Signed-off-by: Daniel Kec <[email protected]>
@danielkec
Fix nullability
044238e 
Signed-off-by: Daniel Kec <[email protected]>
@danielkec danielkec changed the title 2286 npe fix Fix NPE on error in tx #2286 Oct 12, 2020
@danielkec danielkec self-assigned this Oct 12, 2020
@danielkec danielkec added the DB client Helidon DB Client label Oct 12, 2020
@Tomas-Kraus
Copy link
Member

Tomas-Kraus commented Oct 12, 2020 •
edited
Loading

There is still something wrong:
DB clients tests on master:

kratz@mbp:/data/helidon-master>mvn clean install -DskipTests -T8
...
kratz@mbp:/data/helidon-master/tests/integration/dbclient>mvn clean install -Dmysql -Pdocker -pl common,jdbc
[INFO] Tests run: 141, Failures: 0, Errors: 0, Skipped: 0

DB clients tests on PR branch:

kratz@mbp:/data/helidon-pr2436>mvn clean install -DskipTests -T8
...
kratz@mbp:/data/helidon-pr2436/tests/integration/dbclient>mvn clean install -Dmysql -Pdocker -pl common,jdbc
[ERROR] Tests run: 141, Failures: 20, Errors: 7, Skipped: 0

I removed ~/.m2/repository before tests and did full Helidon rebuild before each run.

@danielkec
Fix single result handling
c1973c2 
Signed-off-by: Daniel Kec <[email protected]>
@danielkec
Copy link
Contributor Author

@Tomas-Kraus Can I ask for retest? It passes for me locally

@Tomas-Kraus
Copy link
Member

Mysql:

[INFO] Tests run: 141, Failures: 0, Errors: 0, Skipped: 0

Mariadb:

[INFO] Tests run: 141, Failures: 0, Errors: 0, Skipped: 0

PostgreSQL

[INFO] Tests run: 141, Failures: 0, Errors: 0, Skipped: 0

MS SQL Server

[INFO] Tests run: 141, Failures: 0, Errors: 0, Skipped: 0

Tomas-Kraus
Tomas-Kraus approved these changes Oct 14, 2020
View reviewed changes
Copy link
Member

@Tomas-Kraus Tomas-Kraus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@danielkec danielkec merged commit 52734e1 into helidon-io:master Oct 14, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Tomas-Kraus Tomas-Kraus Tomas-Kraus approved these changes

@tomas-langer tomas-langer Awaiting requested review from tomas-langer

Assignees

@danielkec danielkec

Labels
DB client Helidon DB Client
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

DbClient - NullPointerException inTransaction with failing statement
2 participants
@danielkec @Tomas-Kraus