Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DB Client doc for issue 1629 #1652

Merged
merged 21 commits into from
Jun 4, 2020
Merged

DB Client doc for issue 1629 #1652

merged 21 commits into from
Jun 4, 2020

Conversation

ljamen
Copy link
Contributor

@ljamen ljamen commented Apr 15, 2020

This is a first draft of the DB Client doc for 2.0

@ljamen ljamen requested a review from m0mus April 15, 2020 21:40
@m0mus
Copy link
Contributor

m0mus commented Apr 16, 2020

It's good for the first draft. Please add [WiP] to the title.

@ljamen ljamen changed the title DB Client doc for 1629 [WiP] DB Client doc for 1629 Apr 16, 2020
@ljamen ljamen changed the title [WiP] DB Client doc for 1629 DB Client doc for issue 1629 Apr 24, 2020
@ljamen ljamen requested a review from tomas-langer April 24, 2020 13:50
@ljamen ljamen mentioned this pull request May 5, 2020
Closed
46 tasks
m0mus
m0mus requested changes May 13, 2020
View reviewed changes
@m0mus m0mus requested a review from Tomas-Kraus May 13, 2020 17:19
Tomas-Kraus
Tomas-Kraus previously approved these changes May 14, 2020
View reviewed changes
Copy link
Member

@Tomas-Kraus Tomas-Kraus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is just a single cosmetic issue. Otherwise looks good.

@ljamen ljamen requested review from m0mus and Tomas-Kraus May 14, 2020 16:56
ljamen
ljamen commented May 21, 2020
View reviewed changes
Copy link
Contributor Author

@ljamen ljamen left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fixed all change requests; @Tomas-Kraus @m0mus

ljamen
ljamen commented May 28, 2020
View reviewed changes
Copy link
Contributor Author

@ljamen ljamen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

changes complete.

@tomas-langer tomas-langer merged commit 473f60c into helidon-io:master Jun 4, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tomas-langer tomas-langer tomas-langer approved these changes

@m0mus m0mus Awaiting requested review from m0mus

@Tomas-Kraus Tomas-Kraus Awaiting requested review from Tomas-Kraus

Assignees
No one assigned
Labels
docs
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@ljamen @m0mus @tomas-langer @Tomas-Kraus