-
Notifications
You must be signed in to change notification settings - Fork 568
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adds a default send(Throwable) method to ServerResponse.java as the first step in providing an easy facility for reporting exceptions during HTTP processing #1378
Adds a default send(Throwable) method to ServerResponse.java as the first step in providing an easy facility for reporting exceptions during HTTP processing #1378
Conversation
…irst step in providing an easy facility for reporting exceptions during HTTP processing. Signed-off-by: Laird Nelson <[email protected]>
See issue #878. |
Signed-off-by: Laird Nelson <[email protected]>
Signed-off-by: Laird Nelson <[email protected]>
…odyWriter.java Signed-off-by: Laird Nelson <[email protected]>
|
Signed-off-by: Laird Nelson <[email protected]>
media/common/src/main/java/io/helidon/media/common/ContentWriters.java
Outdated
Show resolved
Hide resolved
media/common/src/main/java/io/helidon/media/common/ContentWriters.java
Outdated
Show resolved
Hide resolved
webserver/webserver/src/main/java/io/helidon/webserver/ServerResponse.java
Outdated
Show resolved
Hide resolved
… discussion Signed-off-by: Laird Nelson <[email protected]>
…ter-furnishing method in ContentWriters.java per discussion Signed-off-by: Laird Nelson <[email protected]>
…StackTrace method in ContentWriters.java per discussion Signed-off-by: Laird Nelson <[email protected]>
Signed-off-by: Laird Nelson <[email protected]>
…per direction Signed-off-by: Laird Nelson <[email protected]>
…per and into the write method per instruction Signed-off-by: Laird Nelson <[email protected]>
Signed-off-by: Laird Nelson <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think it would be useful to have a configurable option for this writer:
- send a message (maybe also configurable) "Internal server error"
- send the stack trace across the network
Sending a stack trace by default is sometimes considered a security issue, as you leak internal information about your implementation. So it is really useful for development and troubleshooting, but should not be used in production.
Yes, the configuration will be a separate follow-on issue (see #1392), as Romain and I decided that getting configuration into |
Thanks; I'll merge this soon and then start work on #1392. |
Thanks for explanation, approved. |
This PR, when ready, will add the ability to conveniently send a
Throwable
during HTTP processing.Signed-off-by: Laird Nelson [email protected]