Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Theme - No navigation #729

Closed
bakes82 opened this issue Sep 2, 2020 · 12 comments
Closed

Theme - No navigation #729

bakes82 opened this issue Sep 2, 2020 · 12 comments

Comments

@bakes82
Copy link

bakes82 commented Sep 2, 2020

Is there a theme example with no navigation? Use case would be a landing page, or maybe hidden from navigation form pages.

I deployed to azure, setup, I see the cerulean theme. Press download, then install and it doesnt error loading spinner spins and then just comes back to same page to say install the theme again.

@sbwalker
Copy link
Member

sbwalker commented Sep 2, 2020

The Cerulean theme source code is available here: https://github.com/oqtane/oqtane.theme.cerulean. For a theme without navigation you could copy Default.razor to create a new component ( ie. NoNav.razor ). Remove the < Menu Orientation="Horizontal" / > from the markup.

@bakes82
Copy link
Author

bakes82 commented Sep 2, 2020

And by making it a new component that would make it toggle from the page ui when you select it I guess. Still going thru everything.

@markdav-is
Copy link
Contributor

I build a theme with custom navigation here: https://github.com/DarkMatterOregon/oqtane.theme.newco
To remove or change the navigation, edit the default.razor file

@bakes82
Copy link
Author

bakes82 commented Sep 3, 2020

Im looking for 1 theme, where when you make a page you can say this page doesnt have navigation. So Im trying to figure out what needs to be done to make that toggle. Im not sure how the Default is being inherited down and where the other pages are placing their code.
I assume it should be working something like the old master page template system but its just not clicking for me yet lol.

@markdav-is
Copy link
Contributor

I guess picking a base theme would be good, then you can copy it. give it a new namespace, then delete the nav from default. I crated the NewCo theme from Cerulean that way. The trick is avoiding hacking away on your local copy of the fremework, but you can start there for some quick progress. You can find the theme components in client/themes
image

@bakes82
Copy link
Author

bakes82 commented Sep 3, 2020

I think your repo is private.

@markdav-is
Copy link
Contributor

it's public now!

@bakes82
Copy link
Author

bakes82 commented Sep 14, 2020

@sbwalker I tried installing the cerilium theme, doesnt install, restart the project it now wont start and tells me that that theme is missing assets.json.

Also when using the oqtane multi pane view, any page saved with this doesnt seem to do anything, I press edit again the theme is blanked out/reset I dont see any way to make a module go to the Left/Right/Top/Center/Bottom. Is there a demo environment. Im assuming all is configured correctly.

@sbwalker
Copy link
Member

It appears that there is a bug in the theme installer logic. I will investigate further.

@sbwalker
Copy link
Member

I confirmed there is a bug in the theme installer/uninstaller. In addition, there is a bug related to Layouts in the Router. I am testing fixes for both right now.

@bakes82
Copy link
Author

bakes82 commented Sep 15, 2020

Thanks, things didnt seem right to me, glad I wasnt just confused :P

@sbwalker
Copy link
Member

Fixed in #748

@sbwalker sbwalker closed this as completed Oct 8, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants