From 288cb9366fddcf328d6eb04fdb7158e35164b9e3 Mon Sep 17 00:00:00 2001 From: shaharyarsheikh Date: Fri, 28 Jan 2022 10:31:46 +0500 Subject: [PATCH 1/3] initial draft --- src/client.ts | 2 ++ src/index.ts | 2 +- 2 files changed, 3 insertions(+), 1 deletion(-) diff --git a/src/client.ts b/src/client.ts index af262eac..66bc0755 100644 --- a/src/client.ts +++ b/src/client.ts @@ -924,3 +924,5 @@ class OptimizelyReactSDKClient implements ReactSDKClient { export function createInstance(config: optimizely.Config): OptimizelyReactSDKClient { return new OptimizelyReactSDKClient(config); } + +export type OptimizelyReactSDKClientType = OptimizelyReactSDKClient; diff --git a/src/index.ts b/src/index.ts index 2e117f23..3fd1c8a6 100644 --- a/src/index.ts +++ b/src/index.ts @@ -32,6 +32,6 @@ export { OptimizelyDecideOption, } from '@optimizely/optimizely-sdk'; -export { createInstance, ReactSDKClient } from './client'; +export { createInstance, ReactSDKClient, OptimizelyReactSDKClientType } from './client'; export { default as logOnlyEventDispatcher } from './logOnlyEventDispatcher'; From 7ee3d9afc4d32e072626cd003f94b0e14566bc83 Mon Sep 17 00:00:00 2001 From: shaharyarsheikh Date: Mon, 31 Jan 2022 10:11:55 +0500 Subject: [PATCH 2/3] create instance return type updated --- src/client.ts | 4 +--- src/index.ts | 2 +- 2 files changed, 2 insertions(+), 4 deletions(-) diff --git a/src/client.ts b/src/client.ts index 66bc0755..9c019ac5 100644 --- a/src/client.ts +++ b/src/client.ts @@ -921,8 +921,6 @@ class OptimizelyReactSDKClient implements ReactSDKClient { } } -export function createInstance(config: optimizely.Config): OptimizelyReactSDKClient { +export function createInstance(config: optimizely.Config): ReactSDKClient { return new OptimizelyReactSDKClient(config); } - -export type OptimizelyReactSDKClientType = OptimizelyReactSDKClient; diff --git a/src/index.ts b/src/index.ts index 3fd1c8a6..2e117f23 100644 --- a/src/index.ts +++ b/src/index.ts @@ -32,6 +32,6 @@ export { OptimizelyDecideOption, } from '@optimizely/optimizely-sdk'; -export { createInstance, ReactSDKClient, OptimizelyReactSDKClientType } from './client'; +export { createInstance, ReactSDKClient } from './client'; export { default as logOnlyEventDispatcher } from './logOnlyEventDispatcher'; From 66477d56748fdd52edf78741a2e92371615442aa Mon Sep 17 00:00:00 2001 From: shaharyarsheikh Date: Mon, 31 Jan 2022 11:50:51 +0500 Subject: [PATCH 3/3] added missing properties in reactSdkClient interface --- src/client.ts | 3 +++ 1 file changed, 3 insertions(+) diff --git a/src/client.ts b/src/client.ts index 9c019ac5..4cdc1f12 100644 --- a/src/client.ts +++ b/src/client.ts @@ -168,6 +168,9 @@ export interface ReactSDKClient extends Omit