Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bug: On proposed changes files section, comments appear duplicated #1537

Closed
bilalabbad opened this issue Nov 29, 2023 · 0 comments
Closed

bug: On proposed changes files section, comments appear duplicated #1537

bilalabbad opened this issue Nov 29, 2023 · 0 comments
Assignees
@bilalabbad
Labels
group/frontend Issue related to the frontend (React) state/ref This issue is referenced in our internal tooling type/bug Something isn't working as expected

Comments

@bilalabbad
Copy link
Contributor

Component

Frontend UI

Current Behavior

On a proposed changes, when adding a comment on afile it is duplicated. One on the correct line, the duplicate on the bottom.
image

Expected Behavior

Comments/thread should appear only once, on the correct line.

Steps to Reproduce

  1. link Infrahub to a GitHub repository
  2. Create a branch which is not data only (Ex name: test-bug)
  3. On github, select the newly created branch named test-bug
  4. On github and on branch test-bug, Edit a template file and commit it
  5. On Infrahub, create a proposed changes for branch test-bug
  6. Select Files Tab on the newly created proposed changes
  7. Add a comment on any line
  8. You should see the bug

Additional Information

No response
@bilalabbad bilalabbad added type/bug Something isn't working as expected group/frontend Issue related to the frontend (React) labels Nov 29, 2023
@bilalabbad bilalabbad changed the title bug: On proposed changes, comments appeared duplicate bug: On proposed changes, comments appeared duplicated Nov 29, 2023
@bilalabbad bilalabbad changed the title bug: On proposed changes, comments appeared duplicated bug: On proposed changes, comments appear duplicated Nov 29, 2023
@bilalabbad bilalabbad changed the title bug: On proposed changes, comments appear duplicated bug: On proposed changes files section, comments appear duplicated Nov 29, 2023
@BeArchiTek BeArchiTek added the state/ref This issue is referenced in our internal tooling label Nov 29, 2023
@bilalabbad bilalabbad self-assigned this Nov 29, 2023
@bilalabbad bilalabbad mentioned this issue Nov 29, 2023
Merged
@pa-lem pa-lem closed this as completed Dec 5, 2023
@bilalabbad bilalabbad mentioned this issue Dec 21, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@bilalabbad bilalabbad

Labels
group/frontend Issue related to the frontend (React) state/ref This issue is referenced in our internal tooling type/bug Something isn't working as expected
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@BeArchiTek @bilalabbad @pa-lem