Fixed most 'readonly' sonar issues (#7624)

Signed-off-by: ClementBouvierN <[email protected]>

Author: ClementBouvierN

ui/main/src/app/business/common/jsontoarray/json-to-array.ts

@@ -42,14 +42,12 @@ export class JsonToArray {
                 this.fieldsProcessOnlyIfPreviousArraysAreEmpty.add(rule.jsonField);
             rule.fields.forEach((field) => this.processRule(field, true));
             this.nestedJsonToArrays.set(rule.jsonField, new JsonToArray(rule.fields));
-        } else {
-            if (rule.columnName) {
-                this.addColumn(rule.columnName);
-                if (!innerRule)
-                    this.fieldDescriptions.push(
-                        new FieldDescription(rule.jsonField, rule.type, this.columnIndexes.get(rule.columnName), false)
-                    );
-            }
+        } else if (rule.columnName) {
+            this.addColumn(rule.columnName);
+            if (!innerRule)
+                this.fieldDescriptions.push(
+                    new FieldDescription(rule.jsonField, rule.type, this.columnIndexes.get(rule.columnName), false)
+                );
         }
     }
 

ui/main/src/app/business/services/global-style.service.ts

@@ -15,8 +15,8 @@ import {MenuService} from 'app/business/services/menu.service';
 declare const opfabStyle: any;
 
 export class GlobalStyleService {
-    public static DAY = 'DAY';
-    public static NIGHT = 'NIGHT';
+    public static readonly DAY = 'DAY';
+    public static readonly NIGHT = 'NIGHT';
 
     private static style: string;
 

ui/main/src/app/business/view/notificationConfiguration/notificationConfiguration.view.ts

@@ -33,7 +33,7 @@ export class NotificationConfigurationView {
     private setEmailEnabled: Function = () => {};
     private notificationConfigurationPage: NotificationConfigurationPage;
     private processList: ProcessForNotification[] = [];
-    private translationService: TranslationService;
+    private readonly translationService: TranslationService;
     private lastProcessesStatesNotNotifiedSaved;
     private lastProcessesStatesNotifiedByEmailSaved;
 

ui/main/src/app/business/view/realtimeusers/realtimeusers.view.ts

@@ -25,13 +25,13 @@ import {Utilities} from 'app/business/common/utilities';
 
 export class RealtimeUsersView {
     private realtimePage: RealtimePage;
-    private realtimeScreens: RealtimePageScreen[] = [];
-    private connectedUsersPerEntity: Map<string, string[]> = new Map<string, string[]>();
-    private connectedUsersGroups: Map<string, string[]> = new Map<string, string[]>();
-    private pageLoaded = new ReplaySubject<RealtimePage>(1);
+    private readonly realtimeScreens: RealtimePageScreen[] = [];
+    private readonly connectedUsersPerEntity: Map<string, string[]> = new Map<string, string[]>();
+    private readonly connectedUsersGroups: Map<string, string[]> = new Map<string, string[]>();
+    private readonly pageLoaded = new ReplaySubject<RealtimePage>(1);
     private updateInterval;
 
-    constructor(private configServer: ConfigServer) {
+    constructor(private readonly configServer: ConfigServer) {
         this.init();
     }
 

ui/main/src/app/business/view/timeline/timeline.view.ts

@@ -15,16 +15,16 @@ import {OpfabStore} from 'app/business/store/opfabStore';
 import {DateTimeFormatterService} from 'app/business/services/date-time-formatter.service';
 
 export class TimelineView {
-    private circles: Circles;
-    private xAxis: XAxis;
+    private readonly circles: Circles;
+    private readonly xAxis: XAxis;
     private domainId: string;
     private title: string;
     private gridTimeDomain: any;
     private cardsTimeDomain: any;
-    private ngUnsubscribe$ = new Subject<void>();
+    private readonly ngUnsubscribe$ = new Subject<void>();
 
-    private circlesSubject = new Subject<Circle[]>();
-    private filteredLightCardStore: FilteredLightCardsStore;
+    private readonly circlesSubject = new Subject<Circle[]>();
+    private readonly filteredLightCardStore: FilteredLightCardsStore;
 
     constructor() {
         this.filteredLightCardStore = OpfabStore.getFilteredLightCardStore();

ui/main/src/app/business/view/timeline/xaxis.ts

@@ -23,7 +23,7 @@ export class XAxis {
     private ticks: Array<Date> = [];
     private ticksLabel: Map<number, string> = new Map<number, string>();
 
-    private tickSizeMap = {
+    private readonly tickSizeMap = {
         RT: {minutes: 15},
         J: {minutes: 30},
         '7D': {hours: 4},
@@ -111,7 +111,7 @@ export class XAxis {
         });
     }
 
-    private computeTickLabel = (value: Date, domainId: string): string => {
+    private readonly computeTickLabel = (value: Date, domainId: string): string => {
         switch (domainId) {
             case 'RT':
                 if (value.getMinutes() === 0) return DateTimeFormatterService.getFormattedDate(value, 'HH') + 'h';

ui/main/src/app/business/view/userCard/cardBuilder/cardBuilder.ts

@@ -28,7 +28,7 @@ export class CardBuilder {
     private editionMode: EditionMode;
     private endDate: number;
     private expirationDate: number;
-    private inputFieldVisibility: Map<InputFieldName, boolean> = new Map();
+    private readonly inputFieldVisibility: Map<InputFieldName, boolean> = new Map();
     private lttd: number;
     private processId: string;
     private processVersion: string;

ui/main/src/app/business/view/userCard/datesForm/datesForm.ts

@@ -14,8 +14,8 @@ import {Card} from '@ofModel/card.model';
 import {CurrentUserCardAPI} from 'app/api/currentusercard.api';
 
 export class DatesForm {
-    private static ONE_MINUTE = 60000;
-    private static ONE_DAY = 60000 * 60 * 24;
+    private static readonly ONE_MINUTE = 60000;
+    private static readonly ONE_DAY = 60000 * 60 * 24;
 
     private endDate: number;
     private endDateVisible: boolean;
@@ -28,9 +28,9 @@ export class DatesForm {
     private startDateVisible: boolean;
     private stateId: string;
 
-    private dateFields = ['startDate', 'endDate', 'lttd', 'expirationDate'];
+    private readonly dateFields = ['startDate', 'endDate', 'lttd', 'expirationDate'];
 
-    constructor(private userCardUIControl: UserCardUIControl) {}
+    constructor(private readonly userCardUIControl: UserCardUIControl) {}
 
     public initDatesBeforeTemplateScriptsExecution(
         processId: string,

ui/main/src/app/business/view/userCard/keepChildCardsForm/keepChildCardsForm.ts

@@ -17,7 +17,7 @@ export class KeepChildCardsForm {
     private keepChildCards: boolean;
     private keepChildCardsVisible: boolean = false;
 
-    constructor(private userCardUIControl: UserCardUIControl) {}
+    constructor(private readonly userCardUIControl: UserCardUIControl) {}
 
     public setValueAndVisibility(
         processId: string,

ui/main/src/app/business/view/userCard/processStatesForm/processStatesForm.ts

@@ -44,7 +44,7 @@ export class ProcessStatesForm {
     private selectedStateId: string;
     private currentCard: Card;
 
-    constructor(private userCardUIControl: UserCardUIControl) {}
+    constructor(private readonly userCardUIControl: UserCardUIControl) {}
 
     init(card: Card = undefined) {
         this.currentCard = card;

ui/main/src/app/business/view/userCard/publisherForm/publisherForm.ts

@@ -19,7 +19,7 @@ export class PublisherForm {
     private selectedPublisher: string;
     private editionMode: EditionMode;
 
-    constructor(private userCardUIControl: UserCardUIControl) {}
+    constructor(private readonly userCardUIControl: UserCardUIControl) {}
 
     public setProcessAndState(processId: string, stateId: string, card?: Card, editionMode?: EditionMode) {
         this.editionMode = editionMode;

ui/main/src/app/business/view/userCard/recipientsForm/recipientsForm.ts

@@ -24,9 +24,9 @@ export class RecipientsForm {
     private recipientVisible = false;
     private selectedRecipients: string[] = [];
     private selectedRecipientsForInformation: string[] = [];
-    private useDescriptionFieldForEntityList = false;
+    private readonly useDescriptionFieldForEntityList = false;
 
-    constructor(private userCardUIControl: UserCardUIControl) {
+    constructor(private readonly userCardUIControl: UserCardUIControl) {
         this.useDescriptionFieldForEntityList = ConfigService.getConfigValue(
             'usercard.useDescriptionFieldForEntityList',
             false

ui/main/src/app/business/view/userCard/severityForm/severityForm.ts

@@ -17,7 +17,7 @@ export class SeverityForm {
     private selectedSeverity: Severity;
     private severityVisible: boolean;
 
-    constructor(private userCardUIControl: UserCardUIControl) {}
+    constructor(private readonly userCardUIControl: UserCardUIControl) {}
 
     public setProcessAndState(processId: string, stateId: string, card: Card = undefined) {
         const state = ProcessesService.getProcess(processId).states.get(stateId);

ui/main/src/app/business/view/userCard/userCard.view.ts

@@ -68,14 +68,14 @@ export class UserCardView {
     private existingCard: Card;
     private existingChildCards: Card[];
     private datesForm: DatesForm;
-    private processStatesForm: ProcessStatesForm;
-    private publisherForm: PublisherForm;
+    private readonly processStatesForm: ProcessStatesForm;
+    private readonly publisherForm: PublisherForm;
     private recipientsForm: RecipientsForm;
-    private severityForm: SeverityForm;
-    private keepChildCardsForm: KeepChildCardsForm;
+    private readonly severityForm: SeverityForm;
+    private readonly keepChildCardsForm: KeepChildCardsForm;
     private useCurrentDateForCardStartDate: boolean;
 
-    constructor(private userCardUIControl: UserCardUIControl) {
+    constructor(private readonly userCardUIControl: UserCardUIControl) {
         this.processStatesForm = new ProcessStatesForm(this.userCardUIControl);
         this.publisherForm = new PublisherForm(this.userCardUIControl);
         this.severityForm = new SeverityForm(this.userCardUIControl);

ui/main/src/app/business/view/useractionlogs/userActionLogs.view.ts

@@ -26,16 +26,16 @@ import {UserActionLogsPageDescription} from './userActionLogsPageDescription';
 import {ExcelExport} from '../../common/excel-export';
 
 export class UserActionLogsView {
-    private userActionLogPage = new UserActionLogsPageDescription();
+    private readonly userActionLogPage = new UserActionLogsPageDescription();
     private selectedLogins: string[] = [];
     private selectedActions: string[] = [];
     private dateFrom = 0;
     private dateTo = 0;
     private pageNumber = 0;
 
     constructor(
-        private translationService: TranslationService,
-        private userActionLogsServer: UserActionLogsServer
+        private readonly translationService: TranslationService,
+        private readonly userActionLogsServer: UserActionLogsServer
     ) {
         this.initPage();
     }

ui/main/src/app/modules/activityarea/activityarea.component.ts

@@ -42,10 +42,10 @@ export class ActivityareaComponent implements OnInit, OnDestroy {
     activityAreaView: ActivityAreaView;
     activityAreaPage: ActivityAreaPage;
 
-    private canDeactivateSubject = new Subject<boolean>();
-    private ngUnsubscribe$ = new Subject<void>();
+    private readonly canDeactivateSubject = new Subject<boolean>();
+    private readonly ngUnsubscribe$ = new Subject<void>();
 
-    constructor(private modalService: NgbModal) {}
+    constructor(private readonly modalService: NgbModal) {}
 
     ngOnInit() {
         this.activityAreaView = new ActivityAreaView();

ui/main/src/app/modules/admin/admin.component.ts

@@ -9,7 +9,7 @@
  */
 
 import {ChangeDetectionStrategy, Component, OnInit} from '@angular/core';
-import {ActivatedRoute, RouterLink, RouterLinkActive, RouterOutlet} from '@angular/router';
+import {RouterLink, RouterLinkActive, RouterOutlet} from '@angular/router';
 import {TranslateService, TranslateModule} from '@ngx-translate/core';
 import {SharingService} from './services/sharing.service';
 import {NgFor} from '@angular/common';
@@ -28,9 +28,8 @@ export class AdminComponent implements OnInit {
     public paginationPageSizeOptions = [5, 10, 25, 50, 100];
 
     constructor(
-        private route: ActivatedRoute,
         protected translate: TranslateService,
-        private dataHandlingService: SharingService
+        private readonly dataHandlingService: SharingService
     ) {}
 
     ngOnInit() {

ui/main/src/app/modules/admin/components/cell-renderers/action-cell-renderer.component.ts

@@ -27,7 +27,7 @@ export class ActionCellRendererComponent implements ICellRendererAngularComp {
     public actionType: string;
 
     // Defines icons to display depending on action type
-    private actionIconsMapping = {
+    private readonly actionIconsMapping = {
         edit: 'fas fa-pen',
         delete: 'far fa-trash-alt',
         download: 'fas fa-download',

ui/main/src/app/modules/admin/components/cell-renderers/role-cell-renderer.component.ts

@@ -30,7 +30,7 @@ export class RoleCellRendererComponent implements ICellRendererAngularComp {
     entities: Entity[];
     _roles = [];
 
-    constructor(private translationService: TranslationService) {
+    constructor(private readonly translationService: TranslationService) {
         this.entities = EntitiesService.getEntities();
     }
 

ui/main/src/app/modules/admin/components/editmodal/entities/edit-entity-modal.component.ts

@@ -84,11 +84,11 @@ export class EditEntityModalComponent implements OnInit {
     private crudService: CrudService;
 
     constructor(
-        private translationService: TranslationService,
-        private translate: TranslateService,
-        private activeModal: NgbActiveModal,
-        private dataHandlingService: SharingService,
-        private changeDetector: ChangeDetectorRef
+        private readonly translationService: TranslationService,
+        private readonly translate: TranslateService,
+        private readonly activeModal: NgbActiveModal,
+        private readonly dataHandlingService: SharingService,
+        private readonly changeDetector: ChangeDetectorRef
     ) {}
 
     ngOnInit() {

ui/main/src/app/modules/admin/components/editmodal/groups/edit-group-modal.component.ts

@@ -85,9 +85,9 @@ export class EditGroupModalComponent implements OnInit {
     };
 
     constructor(
-        private activeModal: NgbActiveModal,
-        private dataHandlingService: SharingService,
-        private changeDetector: ChangeDetectorRef
+        private readonly activeModal: NgbActiveModal,
+        private readonly dataHandlingService: SharingService,
+        private readonly changeDetector: ChangeDetectorRef
     ) {
         Object.values(PermissionEnum).forEach((t) => this.groupPermissions.push({value: String(t), label: String(t)}));
     }

ui/main/src/app/modules/admin/components/editmodal/perimeters/edit-perimeter-modal.component.ts

@@ -40,8 +40,8 @@ import {MultiSelectComponent} from '../../../../share/multi-select/multi-select.
 })
 export class EditPerimeterModalComponent implements OnInit {
     constructor(
-        private activeModal: NgbActiveModal,
-        private changeDetector: ChangeDetectorRef
+        private readonly activeModal: NgbActiveModal,
+        private readonly changeDetector: ChangeDetectorRef
     ) {
         Object.keys(RightsEnum).forEach((key) => {
             this.rightOptions.push({value: key, label: key});

ui/main/src/app/modules/admin/components/table/admin-table.directive.ts

@@ -91,13 +91,13 @@ export abstract class AdminTableDirective implements OnDestroy {
 
     protected i18NPrefix = 'admin.input.';
     protected crudService: CrudService;
-    private currentUserLogin;
+    private readonly currentUserLogin;
 
     constructor(
         protected translateService: TranslateService,
         protected modalService: NgbModal,
         protected dataHandlingService: SharingService,
-        private changeDetector: ChangeDetectorRef
+        private readonly changeDetector: ChangeDetectorRef
     ) {
         this.currentUserLogin = UserService.getCurrentUserWithPerimeters().userData.login;
         this.processesDefinition = ProcessesService.getAllProcesses();

ui/main/src/app/modules/admin/services/sharing.service.ts

@@ -23,14 +23,14 @@ import {CrudSupervisedEntitiesService} from 'app/business/services/admin/crud-su
 @Injectable()
 export class SharingService implements OnDestroy {
     private readonly _paginationPageSize$: ReplaySubject<number>;
-    private unsubscribe$: Subject<void> = new Subject<void>();
-    private crudUserService: CrudUserService;
-    private crudEntitiesService: CrudEntitiesService;
-    private crudGroupsService: CrudGroupsService;
-    private crudPerimetersService: CrudPerimetersService;
-    private crudProcessesService: CrudProcessesService;
-    private crudBusinessDataService: CrudBusinessDataService;
-    private supervisedEntitiesService: CrudSupervisedEntitiesService;
+    private readonly unsubscribe$: Subject<void> = new Subject<void>();
+    private readonly crudUserService: CrudUserService;
+    private readonly crudEntitiesService: CrudEntitiesService;
+    private readonly crudGroupsService: CrudGroupsService;
+    private readonly crudPerimetersService: CrudPerimetersService;
+    private readonly crudProcessesService: CrudProcessesService;
+    private readonly crudBusinessDataService: CrudBusinessDataService;
+    private readonly supervisedEntitiesService: CrudSupervisedEntitiesService;
 
     constructor() {
         this._paginationPageSize$ = new ReplaySubject<number>();

ui/main/src/app/modules/archives/archives.component.ts

@@ -114,9 +114,9 @@ export class ArchivesComponent implements OnDestroy, OnInit {
     displayContext: any = DisplayContext.ARCHIVE;
 
     constructor(
-        private translationService: TranslationService,
-        private modalService: NgbModal,
-        private changeDetector: ChangeDetectorRef
+        private readonly translationService: TranslationService,
+        private readonly modalService: NgbModal,
+        private readonly changeDetector: ChangeDetectorRef
     ) {
         ProcessesService.getAllProcesses().forEach((process) => {
             let itemName = process.name;

ui/main/src/app/modules/card/card.component.ts

@@ -80,12 +80,10 @@ export class CardComponent implements OnInit, OnDestroy {
                             }
                         }
                     });
-                } else {
-                    if (selectedCard.notFound) {
-                        this.cardNotFound = true;
-                        this.cardLoadingInProgress = false;
-                        LoggerService.warn('Card not found.');
-                    }
+                } else if (selectedCard.notFound) {
+                    this.cardNotFound = true;
+                    this.cardLoadingInProgress = false;
+                    LoggerService.warn('Card not found.');
                 }
             });
         this.checkForCardLoadingInProgressForMoreThanOneSecond();

ui/main/src/app/modules/card/components/card-ack/card-ack.component.ts

@@ -59,7 +59,7 @@ export class CardAckComponent implements OnInit, OnChanges, OnDestroy {
 
     public user: User;
 
-    private unsubscribe$: Subject<void> = new Subject<void>();
+    private readonly unsubscribe$: Subject<void> = new Subject<void>();
     isReadOnlyUser: any;
 
     cardProcess: Process;