cmd/operator-sdk: fix run local flags #2478
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
openshift-ci-robot
added
the
size/XS
|
@joelanford Done. Thank you for reviewing this. |
joelanford
reviewed
Jan 28, 2020
CHANGELOG.md
Outdated
| @@ -11,6 +11,7 @@ | |||
| ### Bug Fixes | |||
|
|
|||
| - Fixed issue with Go dependencies caused by removed tag in `openshift/api` repository ([#2466](https://github.com/operator-framework/operator-sdk/issues/2466)) | |||
| - Fixed a regression in the `operator-sdk run` command that caused `--local` flags to be ignored (#2478) | |||
There was a problem hiding this comment.
Suggested change
| - Fixed a regression in the `operator-sdk run` command that caused `--local` flags to be ignored (#2478) | |
| - Fixed a regression in the `operator-sdk run` command that caused `--local` flags to be ignored ([#2478](https://github.com/operator-framework/operator-sdk/issues/2478)) |
There was a problem hiding this comment.
Sorry, my bad. I've missed that. Fixed.
There was a problem hiding this comment.
No worries. I should have been more clear the first time :)
|
/lgtm |
This was referenced Feb 10, 2020
Closed
camilamacedo86
added a commit
that referenced
this pull request
Feb 11, 2020
* CHANGELOG.md: update for next release Co-authored-by: Liran Polak <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #2477.