Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revert prometheus/client_golang dependency to v0.9.x instead of v1.0.0 #2189

Closed
joelanford opened this issue Nov 13, 2019 · 2 comments
Closed

Revert prometheus/client_golang dependency to v0.9.x instead of v1.0.0 #2189

joelanford opened this issue Nov 13, 2019 · 2 comments
Assignees
@joelanford
Labels
area/dependency Issues or PRs related to dependency changes kind/bug Categorizes issue or PR as related to a bug.

Comments

@joelanford
Copy link
Member

See kubernetes-sigs/controller-runtime#660
@joelanford joelanford added kind/bug Categorizes issue or PR as related to a bug. area/dependency Issues or PRs related to dependency changes labels Nov 13, 2019
@joelanford joelanford self-assigned this Nov 13, 2019
@joelanford
Copy link
Member Author

Looks like this will be more difficult for us because kube-state-metrics also depends on prometheus/[email protected].

kube-state-metrics was bumped to v1.7.2 in #1943. And it appears that there might be compatibility issues between kube-state-metrics v1.6.0 and Go 1.13. So we may not be able to solve this without undoing quite a bit.

Users who need compatibility with k8s.io/component-base in Kuberetes 1.15 and 1.16 might need to use a replace in their go.mod files to force the use of prometheus/[email protected]

@joelanford
Copy link
Member Author

This bug is not fixable due to Helm 3's requirement on prometheus/[email protected]

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@joelanford joelanford

Labels
area/dependency Issues or PRs related to dependency changes kind/bug Categorizes issue or PR as related to a bug.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@joelanford