Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SDK should work outside of $GOPATH/src #1457

Closed
estroz opened this issue May 20, 2019 · 0 comments · Fixed by #1475
Closed

SDK should work outside of $GOPATH/src #1457

estroz opened this issue May 20, 2019 · 0 comments · Fixed by #1475
Assignees

Comments

@estroz
Copy link
Member

estroz commented May 20, 2019

Feature Request

Is your feature request related to a problem? Please describe.
The SDK depends on GOPATH being set in a users' development/build environment to run certain commands. Specifically CheckAndGetProjectGoPkg() requires $GOPATH to get the project's repo, a value used in several scaffolds and pieces of SDK logic.

Describe the solution you'd like
Go modules, which removes the GOPATH requirement for go projects in general, are now usable by existing and new operator projects through the SDK. The SDK should support the same behaviour.

Note: API packages are assumed to be rooted under $GOPATH by k8s.io/gengo, the parsing library used by controller-tools. The SDK uses controller-tools to generate CRD's. Until this issue is fixed (see this comment) the SDK cannot work outside of $GOPATH.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant