Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support groups (private channels and group DMs) in the Slack adapter #973

Closed
vanstee opened this issue Sep 21, 2016 · 0 comments
Closed
Assignees
Labels
Milestone

Comments

@vanstee
Copy link
Member

vanstee commented Sep 21, 2016

After rewriting the slack adapter with the refactored adapter protocol, it looks like we missed private channels (probably because we didn't have an integration test running against them). Let's add back support for them. As far as I can tell, all we need to do is accept both channel and group ids where we are currently only match on channel ids.

Thanks for the heads up @pygillier.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants