Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Apply constraints when deleting relay groups #1349

Merged

Conversation

christophermaier
Copy link
Collaborator

No description provided.

Copy link
Contributor

@mpeck mpeck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The changes look reasonable to me. But I wonder if we would want to provide a way to remove a relay group without having to first remove all memberships and assignments. Maybe like a force remove or something?

But if that's not something we want. This looks good to me 👍

@christophermaier
Copy link
Collaborator Author

@mpeck I think we wanted to avoid making big changes to the API so close to 1.0. In any event, cogctl now has some commands to help with this (e.g. cogctl relay group remove $GROUP --all will remove all relays from a group, and cogctl relay group unassign $GROUP --all unassigns all bundles from a group. If we wanted to, we could easily add a --force flag to cogctl relay group delete $GROUP without touching the API.

This change was to ensure that the API didn't throw a HTTP 500 when you tried to delete a group.

@christophermaier christophermaier merged commit ee26240 into master Feb 14, 2017
@christophermaier christophermaier deleted the cm/enforce-relay-group-constraints-on-delete branch February 14, 2017 15:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants