luci-app-xinetd: incorrect handling of REDIRECT option in the UI

[lars18th]

Is there an existing issue for this?

• I have searched among all existing issues (including closed issues)

screenshots or captures

Hi,

This is related to commit #6194

Actual behaviour

When you want to use the REDIRECT option with the UNLISTED Type, the SERVER option continues to be required. Therefore using the Luci UI you can't add any redirect port.

Expected behaviour

The SERVER option has to be optional if the REDIRECT option is used.

Steps to reproduce

1. go to: Services -> Xinetd
2. Select "Add new service entry"
3. Type Servicename (test), Port (11122) and Redirect (127.0.0.1:22) and press "Save"

You can't

Additional Information

Powered by LuCI openwrt-24.10 branch (25.062.67750~c03591c) / OpenWrt 24.10.0 (r28427-6df0e3d02a)

What browsers do you see the problem on?

No response

Relevant log output

[systemcrash]

@feckert do you have a good idea to fix this?

[lars18th]

@feckert do you have a good idea to fix this?

Yes. Here the idea for the fix:

• Convert the "Redirect" box into a select tick (on/off).
• If "Redirect" is off then "Server" box is visible.
• If "Redirect" is on then "Server" box is disabled, and replaced by a "Redirect" box.

What you think?

[feckert]

@lars18th This should fix your issue #7689
Can you please report back.

[lars18th]

@lars18th This should fix your issue #7689 Can you please report back.

Hi @feckert ,

Tested and working. Ready to merge. Thank you. 👍

[lars18th]

Thank you @feckert