Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update README.md #776

Merged
merged 1 commit into from
Nov 4, 2020
Merged

Update README.md #776

merged 1 commit into from
Nov 4, 2020

Conversation

7brokenmirrors
Copy link
Contributor

Output wasn't dumped to host directory, must be /opt/ instead of /root/

compare:

========== Manager Configuration ==========
{
  "aggregator_address": [
    "127.0.0.1",
    33585
  ],
  "data_directory": "/opt/Desktop/",
  "database_name": "/opt/Desktop/crawl-data.sqlite",
  "failure_limit": null,
  "log_directory": "/opt/Desktop/",
  "log_file": "/opt/Desktop/openwpm.log",
  "logger_address": [
    "127.0.0.1",
    34201
  ],
  "num_browsers": 1,
  "output_format": "local",
  "s3_bucket": null,
  "s3_directory": null,
  "screenshot_path": "/opt/Desktop/screenshots",
  "source_dump_path": "/opt/Desktop/sources",
  "testing": false
}

Output wasn't dumped to host directory, must be /opt/ instead of /root/

compare:

```
========== Manager Configuration ==========
{
  "aggregator_address": [
    "127.0.0.1",
    33585
  ],
  "data_directory": "/opt/Desktop/",
  "database_name": "/opt/Desktop/crawl-data.sqlite",
  "failure_limit": null,
  "log_directory": "/opt/Desktop/",
  "log_file": "/opt/Desktop/openwpm.log",
  "logger_address": [
    "127.0.0.1",
    34201
  ],
  "num_browsers": 1,
  "output_format": "local",
  "s3_bucket": null,
  "s3_directory": null,
  "screenshot_path": "/opt/Desktop/screenshots",
  "source_dump_path": "/opt/Desktop/sources",
  "testing": false
}
```
@codecov
Copy link

codecov bot commented Nov 2, 2020

Codecov Report

Merging #776 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #776   +/-   ##
=======================================
  Coverage   40.06%   40.06%           
=======================================
  Files          29       29           
  Lines        3157     3157           
=======================================
  Hits         1265     1265           
  Misses       1892     1892           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e989ce5...d9ea89f. Read the comment docs.

@vringar
Copy link
Contributor

vringar commented Nov 4, 2020

Thank you for this PR. I don't quite understand why this happens but I could reproduce this behaviour

@vringar vringar merged commit 3135003 into openwpm:master Nov 4, 2020
Zaxeli pushed a commit to Zaxeli/OpenWPM that referenced this pull request Aug 10, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants