Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Good First Issue]: Support aten::lgamma for pytorch models #20583

Closed
mvafin opened this issue Oct 18, 2023 · 18 comments
Closed

[Good First Issue]: Support aten::lgamma for pytorch models #20583

mvafin opened this issue Oct 18, 2023 · 18 comments
Assignees
Labels
category: PyTorch FE OpenVINO PyTorch Frontend good first issue Good for newcomers no_stale Do not mark as stale

Comments

@mvafin
Copy link
Contributor

mvafin commented Oct 18, 2023

Context

OpenVINO component responsible for support of PyTorch models is called as PyTorch Frontend (PT FE). PT FE converts a model represented as TorchScript model to a model in OpenVINO opset.

What needs to be done?

  • Implement conversion rule and/or transformation to support the new operation.
  • Implement operation tests in tests/layer_tests/pytorch_tests. Please consider different data types, but keep reasonable number of test cases

Example Pull Requests

#18998

Resources

Contact points

@openvinotoolkit/openvino-pytorch-frontend-maintainers

Ticket

TBD

@mvafin mvafin added good first issue Good for newcomers no_stale Do not mark as stale labels Oct 18, 2023
@github-project-automation github-project-automation bot moved this to Contrubutors needed in Good first issues Oct 18, 2023
@ilya-lavrenov ilya-lavrenov added the category: PyTorch FE OpenVINO PyTorch Frontend label Oct 18, 2023
@Praveen880890
Copy link

Can i work on this issue? Please assign if not assigned.

@ilya-lavrenov ilya-lavrenov moved this from Contributors Needed to Assigned in Good first issues Oct 22, 2023
@Praveen880890
Copy link

Praveen880890 commented Oct 24, 2023

hi , i was trying to set up your development environment and i got errors
the command i used is
"cmake -DCMAKE_BUILD_TYPE=Debug -DENABLE_PYTHON=ON -DENABLE_TESTS=ON -DENABLE_FUNCTIONAL_TESTS=ON -DENABLE_DEBUG_CAPS=ON -DENABLE_CPU_DEBUG_CAPS=ON -DENABLE_NCC_STYLE=ON .."

Please let me know how i can resolve this issue. I am using wsl(ubuntu) in windows 11

image

@ilya-lavrenov
Copy link
Contributor

Please, use:

git submodule update --init

@Praveen880890
Copy link

again i am getting this error
image

@ilya-lavrenov
Copy link
Contributor

You have issues with git.
It's not connected with OpenVINO

@Praveen880890
Copy link

ok do you know to resolve those issues?
only if you know !
thanks for the reply

@Praveen880890
Copy link

my issue isn't resolved, in the meantime please reassign this to someone else
thank you !

@ilya-lavrenov
Copy link
Contributor

ilya-lavrenov commented Oct 24, 2023

I can advice removing repo and repeat from scratch:

git clone https://github.com/openvinotoolkit/openvino.git
cd openvino
git submodule update --init
mkdir build
cd build
cmake ../
cmake --build . --parallel

@Praveen880890
Copy link

Still facing some issues, maybe my pc isn't supporting
Screenshot 2023-10-25 135411
it has been two hours and no progress, so i guess i can't move further.

@p-wysocki p-wysocki moved this from Assigned to Contributors Needed in Good first issues Oct 27, 2023
@sanbuphy
Copy link

Hi ! Can i try this ? What should I do ( apply for something?

@mvafin
Copy link
Contributor Author

mvafin commented Nov 23, 2023

@sanbuphy I assigned it to you.

@sanbuphy
Copy link

sanbuphy commented Nov 24, 2023

@sanbuphy I assigned it to you.

Hi, I meet compile error when i build openvino, How can i solve this problem? Thanks.

env: ubuntu 22.04 gcc 11.4.0

After I run cmake -DCMAKE_BUILD_TYPE=Release .. make --jobs=$(nproc --all)

image

image

@ilya-lavrenov
Copy link
Contributor

@sanbuphy
Please, remove both ABSL and Protobuf headers and libs from /usr/local folder

@p-wysocki p-wysocki moved this from Contributors Needed to Assigned in Good first issues Nov 24, 2023
@sanbuphy
Copy link

@sanbuphy Please, remove both ABSL and Protobuf headers and libs from /usr/local folder

It works, Thank you!

@sanbuphy
Copy link

sanbuphy commented Nov 26, 2023

@sanbuphy Please, remove both ABSL and Protobuf headers and libs from /usr/local folder

@ilya-lavrenov @p-wysocki
Hi , I want to ask where can get the openvino python whl package after i compiling the openvino source ?
and I want to find the gamma function op on docs opset, but I don't find anything about that (How can i get the 'gamma' node, I also want to find the lower op but it's hard ,maybe i need oneapi.) Thank you very much!

@p-wysocki
Copy link
Contributor

Hello @sanbuphy,

Hi , I want to ask where can get the openvino python whl package after i compiling the openvino source ?

After building and installing OpenVINO with -DENABLE_WHEEL=ON option, it can be found in the install directory, I believe they are installed to tools. I would recommend setting your PYTHONPATH instead of installing wheels, it makes working on OpenVINO significantly easier.

and I want to find the gamma function op on docs opset, but I don't find anything about that (How can i get the 'gamma' node, I also want to find the lower op but it's hard ,maybe i need oneapi.) Thank you very much!

@mvafin could you please take a look?

@mvafin
Copy link
Contributor Author

mvafin commented Dec 7, 2023

I looked into the algorithm to compute gamma function and it appear to be more complex that I was thinking before. It is unlikely it will be effective enough to implement this operation without adding to our opset, I would close this issue. @sanbuphy please check other issues on GFI board

@mvafin mvafin closed this as not planned Won't fix, can't repro, duplicate, stale Dec 7, 2023
@github-project-automation github-project-automation bot moved this from Assigned to Closed in Good first issues Dec 7, 2023
@sanbuphy
Copy link

sanbuphy commented Dec 7, 2023

I looked into the algorithm to compute gamma function and it appear to be more complex that I was thinking before. It is unlikely it will be effective enough to implement this operation without adding to our opset, I would close this issue. @sanbuphy please check other issues on GFI board

Yes, I seem so too. OK

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
category: PyTorch FE OpenVINO PyTorch Frontend good first issue Good for newcomers no_stale Do not mark as stale
Projects
Archived in project
Development

No branches or pull requests

5 participants