Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add password and encryption to private key #164

Merged
merged 20 commits into from
Dec 10, 2019
Merged

Add password and encryption to private key #164

merged 20 commits into from
Dec 10, 2019

Conversation

lego963
Copy link
Contributor

@lego963 lego963 commented Dec 4, 2019 •
edited by outcatcher
Loading

Close #159

outcatcher
outcatcher reviewed Dec 4, 2019
View reviewed changes
Copy link
Contributor

@outcatcher outcatcher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are several strange changes in tf files.

Please limit minimal password length and make some regex for checking too simple passwords

scenarios/modules/bastion/variables.tf Outdated Show resolved Hide resolved
@outcatcher outcatcher added the enhancement New feature or request label Dec 5, 2019
@lego963 lego963 marked this pull request as ready for review December 9, 2019 10:50
@lego963
Copy link
Contributor Author

lego963 commented Dec 9, 2019

Close #159

outcatcher
outcatcher suggested changes Dec 9, 2019
View reviewed changes
Copy link
Contributor

@outcatcher outcatcher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Password is passed via stdin for ssh-add, lets pass it the same for get_key — it seems to be more secure

@anton-sidelnikov anton-sidelnikov merged commit d2680dc into master Dec 10, 2019
@anton-sidelnikov anton-sidelnikov deleted the ench/vault branch December 10, 2019 08:54
@outcatcher outcatcher mentioned this pull request Dec 10, 2019
Open
anton-sidelnikov added a commit that referenced this pull request Dec 13, 2019
@anton-sidelnikov
Revert "Add password and encryption to private key (#164)"
0168243 
This reverts commit d2680dc.
@anton-sidelnikov anton-sidelnikov mentioned this pull request Dec 13, 2019
Merged
outcatcher pushed a commit that referenced this pull request Dec 13, 2019
@anton-sidelnikov @outcatcher
Revert "Add password and encryption to private key (#164)" (#172)
a9f53b2 
This reverts commit d2680dc.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@anton-sidelnikov anton-sidelnikov anton-sidelnikov approved these changes

@outcatcher outcatcher outcatcher approved these changes

Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Use secure storage for credentials
3 participants
@lego963 @outcatcher @anton-sidelnikov