Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Incorrect Korean address field translations #1435

Closed
chiho-kr opened this issue Feb 6, 2025 · 5 comments
Closed

Incorrect Korean address field translations #1435

chiho-kr opened this issue Feb 6, 2025 · 5 comments
Labels
bug Something isn't working

Comments

@chiho-kr
Copy link

chiho-kr commented Feb 6, 2025

URL

https://www.openstreetmap.org/edit?way=223418692#map=19/37.567073/126.976577

How to reproduce the issue?

  1. Open iD Editor in Korean interface.
  2. Look at the address field labels for a feature.
  3. Notice that "시·군·자치구", "Missing en translation", and "하위 지구" appear instead of proper Korean labels like "시·군", "읍·면", "동·리".

Screenshot(s) or anything else?

See also: #10674

When mapping addresses in Korea using iD Editor (in Korean), the address fields do not match the proper Korean administrative divisions. Each address field should use the standard Korean administrative division term. Currently, the UI shows something like:
addr:province = '도'
addr:city → '시·군·자치구' ❌ → "시·군"✅
addr:district → '구'
addr:town → 'Missing en translation' ❌ → "읍·면"✅
addr:subdistrict → '하위 지구' ❌ → "동·리"✅

Image

Which deployed environments do you see the issue in?

Released version at openstreetmap.org/edit

What version numbers does this issue effect?

2.31.0

Which browsers are you seeing this problem on?

Chrome

@ERYpTION
Copy link

ERYpTION commented Feb 6, 2025

Seeing the same when using Danish. Went to see if new translations from Transifex were included in the 2.31.0 update. They are not and instead a lot of these "Missing en translation" error messages all over.

@tyrasd tyrasd added the bug Something isn't working label Feb 6, 2025
@tyrasd
Copy link
Member

tyrasd commented Feb 6, 2025

The missing translation bug is fixed with #1433. The translations will be updated with the upcoming release of the tagging-schema dataset (which is independent from the release of the iD codebase). You and expect it in the coming days.

@tyrasd tyrasd closed this as completed Feb 6, 2025
@tyrasd tyrasd transferred this issue from openstreetmap/iD Feb 6, 2025
@gdabski
Copy link

gdabski commented Feb 13, 2025

Is there any place which actually explains what addr:town stands for, compared to addr:city? Is it only used in Korea?

@chiho-kr
Copy link
Author

Is there any place which actually explains what addr:town stands for, compared to addr:city? Is it only used in Korea?

addr:town stands for 읍(Eup), 면(Myeon), level-8 administrative unit in South Korea.

@gdabski
Copy link

gdabski commented Feb 14, 2025

Then I wonder why isn't it something like town!kr, similar to city!cn or neighbourhood!jp? I'm asking from the position of a translator of these presets. When I am just told to translate Town it is absolutely impossible that I come up with a name suitable for these admin units in my language. neighbourhood!jp has the English text Machi/Chōme/Aza/Koaza, which makes it possible for a translator to understand what the string is really used for.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

4 participants