Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add some more keys to the post_box-preset #7738

Closed
Elefant-aus-Wuppertal opened this issue Jun 25, 2020 · 8 comments
Closed

add some more keys to the post_box-preset #7738

Elefant-aus-Wuppertal opened this issue Jun 25, 2020 · 8 comments
Labels
new contributor opportunity Best for first-time contributors without prior experience. You won’t be assigned; PRs welcome! preset An issue with an OpenStreetMap preset or tag
Milestone

Comments

@Elefant-aus-Wuppertal
Copy link
Contributor

Hi,
I think for amenity=post_box, there could be added some more things to its preset:

@quincylvania quincylvania added preset An issue with an OpenStreetMap preset or tag new contributor opportunity Best for first-time contributors without prior experience. You won’t be assigned; PRs welcome! labels Jun 26, 2020
@Samarath
Copy link

I would like to work on this.

@quincylvania
Copy link
Collaborator

@Samarath Great, welcome! Check out our contributing guide and the presets readme. Let me know if you have any questions.

@Adamant36
Copy link

Adamant36 commented Jul 6, 2020

@Lukas458 I was looking at the usage for post_box:type and they all seem to be about the type of support. So, do you know how it would be different then the support tag? Because it looks like they are used the same to me.

@Elefant-aus-Wuppertal
Copy link
Contributor Author

Elefant-aus-Wuppertal commented Jul 6, 2020

Hmm, okay. In my thoughts there would be a difference between these keys. When you look at post_box:type's wiki page, you can for example find the value "lamp". A post box "lamp" is the kind of its shape to me. Here is what we call "lamp" as a post box in Germany: https://wiki.openstreetmap.org/wiki/File:BRIEFKASTEN_DER_DEUTSCHEN_POST_in_BREITH%C3%9CLEN.JPG

As support, the picture shows a pole. But the support of the "lamp" post box could also be a wall, please look at it in this pic: https://wiki.openstreetmap.org/wiki/File:Gelber_Briefkasten_der_Deutschen_Post.JPG

The same thing for post_box:type=pillar. The post box can be mounted onto the ground directly, but in Germany there's often a little concrete pedestal: https://wiki.openstreetmap.org/wiki/File:Briefkasten_Gie%C3%9Fen_2.jpg
A little one, but its there.

@Adamant36
Copy link

Adamant36 commented Jul 6, 2020

Hhhmm, that sorta makes sense. I guess. But then you have stuff like post_box_type=wall + support=wall. Same goes for the others possibilities. Which just seems wierd and redundent. Everyone knows that a wall post box is supported by the wall that its in. Same goes wiyh a pillar post being supported by the piller. Although technically wall post boxes aren't "supported" by the wall in a traditional sense, but I don't that's something mappers will get. So, I think my main thing is using the support tag. Although it would help describing post boxes like ones that are fences. It could also be the general peoblem with "type" tags. Which aren't really clear and include types of things that aren't really types of things. Like with wall post boxes its more about the location then a type of post box. So I don't know. Id at least say they both need better clarification as to how they are different if both are going to be used and maybe only going with one would be a better option so people don't just duplicate things like with my examples. I do this a lot and even id probably confused as to which tag to use to describe what. It seems rather subjective.

@Elefant-aus-Wuppertal
Copy link
Contributor Author

I see, but at the moment I have no idea how to solve that. So maybe it would be better to exclude adding post_box:type first...

@Adamant36
Copy link

I would say just leave post_box:type out of it. It looks like its an abandoned mostly reject proposal anyway that mainly only worked in UK. There's a post_box:design tag and post_box:mounting. Both of which have semi-high numbers and would be way better then post_box:type. Although they don't have wiki articles or much discussion from what I can tell. But the best options sounds like just going with the support tag for now and waiting until the other tags get worked out.

@quincylvania
Copy link
Collaborator

Done in #7777 by @yyazdi13

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
new contributor opportunity Best for first-time contributors without prior experience. You won’t be assigned; PRs welcome! preset An issue with an OpenStreetMap preset or tag
Projects
None yet
Development

No branches or pull requests

4 participants