Search features box should trim spaces

[boothym]

As per title - sometimes when copying nodes/way/relation IDs from overpass-turbo, I select a leading or following space and include it when pasting. Would be good if these were trimmed.

[kymckay]

I don't think the actual string in the UI should be trimmed, however searching would benefit from stripping out white space for the actual search (for better fuzzy matching)

[boothym]

Perhaps it can be restricted to numeric strings then? Because if I paste in " 107775" or "107775 " (minus the quotation marks) then iD doesn't display the node/way/relation links.

[kymckay]

Apologies, I think I wasn't super clear.

My point is the actual UI string should not change, but for actual searching it could be stripped of whitespace. This would solve the issue here, but also for cases where a user may search for "Pizza Express" when the preset is "PizzaExpress", etc.

[NateGrobe]

Hi. I'm new to open source and was wondering if I could work on this issue?

[quincylvania]

@NateGrobe Welcome, go ahead and give it a shot! The modules/ui.feature_list.js is probably the place for this

[NateGrobe]

I'm having a small issue getting the project to run. I'm getting the error:
Error: Could not load ~/iD/node_modules/es5-ext/array/index.js#/clear (imported by node_modules/ds6-set/polyfill.js)

I checked the imports in es6-map/polyfill.js and they seem fine. The import is as follows:
var clear = require('es5-ext/array/#/clear')

Switching it to an es6 imports didn't fix the issue. I'm just not sure why index.js is being added seemingly randomly to the import path.

I tested this on Windows 10 Pro and PopOs 20.04 and got the same error both times.

[quincylvania]

@NateGrobe Hmm I haven't seen that issue before. I assume you went through all the installation steps? Make sure you're running Node 10, 12, or 14. It'd be easier to discuss if you care to join our slack.

[nisargshh]

I've been greeted with the same issue when cloning the project again running npm run all My node version is v12.16.2.

[quincylvania]

@nisargshh I tried a clean install and am been getting this issue now too. Something must have changed with an in-range dependency but I haven't figured out what yet.

[quincylvania]

@NateGrobe @nisargshh The issue seems to have been caused by @rollup/plugin-node-resolve v8.4.0. I pinned to the prior version for now in de307f3.

[NateGrobe]

@quincylvania Got it running. Really appreciate the help.

[quincylvania]

@NateGrobe No problem, thanks a lot for reporting!

[nisargshh]

@quincylvania Got it to work thanks for the update.

[asi309]

Is this issue still open?

[quincylvania]

@asi309 Yep, we're still working through some issues.