Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Include contextual info in the page title when changing URL parameters #6209

Closed
quincylvania opened this issue Apr 20, 2019 · 4 comments
Closed
Labels
enhancement An enhancement to make an existing feature even better
Milestone

Comments

@quincylvania
Copy link
Collaborator

Changing the URL can add entries to the browser's page history. This would be significantly more useful if we could change the title to include the selected feature and/or map location. I'm not sure if this could work on osm.org but I think it's worth it for ideditor.com and localhost alone.

Screen Shot 2019-04-20 at 4 21 02 PM

@bhousel
Copy link
Member

bhousel commented Apr 23, 2019

We could do number of changes (the code that updates the save button count could do it)

document.title = "iD (60)"

Screenshot 2019-04-23 02 16 17

@CarycaKatarzyna
Copy link
Contributor

I want to solve it. How exactly should title looks? Only 'iD' with number of changes as @bhousel proposed? Or for example with name of selected item like in Google Maps?

@quincylvania quincylvania added the enhancement An enhancement to make an existing feature even better label Jan 15, 2020
@quincylvania
Copy link
Collaborator Author

quincylvania commented Jan 15, 2020

@CarycaKatarzyna I saw you started a branch for this, thanks!

I like the idea of showing the change count in the current title like in Bryan's mockup. This would remind people they have pending edits if they tab away from iD.

However, the titles in the browser history should not include the change count since selecting those links does not revert edits. Instead I think they should be linked to the selection/navigation states, which is #6783.

I'm pretty sure your branch works pretty much like this already 👍

@quincylvania
Copy link
Collaborator Author

I ended up removing the map location part since it was distracting and not particularly useful to most users. Perhaps we could include the local area name instead, e.g. "Tuba City, AZ".

We could do number of changes

I added this too. I couldn't yet figure out how to show it in the current title but not in the history item title, but it's not a big problem.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement An enhancement to make an existing feature even better
Projects
None yet
Development

No branches or pull requests

3 participants