Issues with OSM Wikibase links

[my-na-me]

Starting from this:

Localization >> Fetch multilingual tag descriptions and images from the OSM Wikibase (#5647, thanks @nyurik)

I don't like the current way to offering/showing this to the iD-Editor end-user:
When you click on the "i" (i for information?) then I expect to see an instant view to any help* or a wiki* documentation or a direct link to any help* or a wiki* documentation (*human readable) instead of a link to an option or link to edit any documention.

Current view:

So the option to edit the documentation should not shown in the "i-information" chapter

Expected view:

Or at least below the osm-wiki link:

By the way, why it is telling "There is no documentation available for this key" for highway=service ?

[bhousel]

@my-na-me I'm ok with the links being how they are, but I am concerned that the documentation isn't filled in and links to wrong pages.

@nyurik any ideas what is going on?
I don't see any description for the highway=service tag.
Also the "View documentation" link goes to a Greek page.. the sitelink language looks wrong.

[nyurik]

@my-na-me thx for the feedback! I think we should iterate on the design of the edit link, e.g. we could do this (i'm not a designer, suggestions are welcome):

I do not want to visually separate description from the link to edit that description, as that may cause confusion.

Possible link text:

• [edit]
• [edit or translate]
• [edit description]
• ..?

@bhousel The issue with highway=service was due to the incorrect lang parameter on the wiki page, I fixed it there, and it will be fixed in the data item the next time I run my bot. The wiki docs property (P31) is very new, so some bugs are still lurking. I will also update the bot to ignore the lang param, and instead use the language of the page title. Thx for reporting!

@my-na-me I suspect you didn't see the docs link for highway=service because my bot only filled in that data yesterday, and it might have been after the new version of iD has rolled out.

[nyurik]

P.S. @my-na-me you can also talk to us directly on OSM Slack - get an invite.

[nyurik]

While on the subject of design, should we:

• if both key & tag data items exist, show description for the key AND description for the tag if both are available?
  • what if tag is described in English, but key has the description in the local language?
• offer two [edit] links - for both the tag and for the key data items?

[my-na-me]

@bhousel
Thanks for updating my long title version :-)

I'm not so OK with the link order, I would like to see "View documentation" (=> with link to the osm wiki key=value) as top line.

@nyurik

This looks much better, but as mentioned above, I would like to see "View documentation" (=> with link to the osm wiki key=value) as top line, (as it was - for a long time - before ;-) ).

PS: Thank you for the invitation link, actually I stopped instant-messaging long time ago, after a pause-period I switched to this system. Nowadays this is the one I use (also only on low frequency). If you want, we can meet there.

PSS: I opened a thread in the forum, let’s see if somebody is interested in this topic and we could get some more input.

[nyurik]

@my-na-me I do not think we should show a link to documentation before the short description text. The [edit] should be right next to the description, so that users see how they can change that text, hence the proposed design. Could you sketch what you have in mind? Also, see my other question about possibly showing key + tag descriptions / edit links. Thx!

[nyurik]

P.S. Maybe we should give a visual indication that the description we are showing is about a key (when there is no tag-specific description is available)... Not sure about the best design for that either.

[bhousel]

@nyurik any ideas what is going on?
I don't see any description for the highway=service tag.
Also the "View documentation" link goes to a Greek page.. the sitelink language looks wrong.

Still seeing this today.. @nyurik how often do the cleanup scripts run?

[nyurik]

@bhousel sorry, was a bit swamped with another project. Just ran the bot, and got everything updated. I will work on automating it very soon - so that the moment wiki page is updated, data items reflect that.

[bhousel]

@bhousel sorry, was a bit swamped with another project. Just ran the bot, and got everything updated. I will work on automating it very soon - so that the moment wiki page is updated, data items reflect that.

Thanks @nyurik looks good now 👍

I ended up replacing the link with a simple pencil icon.. I like this!

[nyurik]

@bhousel thanks, looks good! What's the tooltip text?

[bhousel]

@bhousel thanks, looks good! What's the tooltip text?

Oh yeah, it says "edit/translate" on the tooltip.. That just didn't get captured in the screenshot.

[nyurik]

Thanks! Also, what happens when the data item exists, but it does not have description in either user's language nor English? I think we should show a big link "add description" in place of the description text? Note that most likely there will be no "view documentation" link, so it will be the only link shown. Perhaps we should show some big question mark instead of an image too?

[bhousel]

Thanks! Also, what happens when the data item exists, but it does not have description in either user's language nor English?

this seems fine..