Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix duplicate upload bug, improve upload performance #4658

Merged
merged 10 commits into from
Jan 8, 2018
Merged

Fix duplicate upload bug, improve upload performance #4658

merged 10 commits into from
Jan 8, 2018

Conversation

bhousel
Copy link
Member

@bhousel bhousel commented Jan 5, 2018 •
edited
Loading

This will fix a few significant bugs with saving.

bhousel added 5 commits January 4, 2018 15:55
@bhousel
Remove unused var (eslint)
286c093
@bhousel
Don't let modal button cover up header bottom border
954227b
@bhousel
Variable cleanups and formatting
8914d1c
@bhousel
Don't reenter putChangeset, allow reuse of open changeset id
437893e 
We are going to start trying an opportunistic save, then only
start the conflict resolution stuff if the server returns a 409.
Reusing an already open changeset makes sense in this situation.
@bhousel
Improvements to save flow
a63c4a7 
- Attempt fast save first, only perform conflict resolution if necessary (re: #3056)
- Block reentry of save, and dont keep focus on save button (closes #4641)
- Refactor modeSave() for code clarity (avoid shared state in closure variables)
@bhousel bhousel force-pushed the fix_duplicate_saves branch from 0acf3b4 to a63c4a7 Compare January 5, 2018 20:11
bhousel added 5 commits January 5, 2018 18:11
@bhousel
Add conflict checking progress, guard code for user authentication
ac86869
@bhousel
Avoid loading circular relations by storing ids in _loaded object
a22cfe6 
(re: #3056)
@bhousel
Fix escape keybind when conflicts ui is active
590487d 
(re: 4351)
@bhousel
Be more careful about enter/update selection in conflict resolution ui
1b973f3 
This fixes one of the issues in #4351 where the radio button was not
selected. This was likely introduced during the upgrade to d3 v4, now
that enter selections do not automatically flow into update anymore.
(the fix is to add a `merge` to ensure that the `selection.each` actually
has some things to iterate over)
@bhousel
Zooming out should not exit save mode
8472f99 
(closes #4664)
@bhousel bhousel merged commit 45ffa3b into master Jan 8, 2018
@bhousel bhousel deleted the fix_duplicate_saves branch January 8, 2018 15:31
@bhousel bhousel mentioned this pull request Jan 21, 2018
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@bhousel