Switch Topology defaultLabelSelector to lib-common GetLabelSelector #286
Conversation
fmount
force-pushed
the
topology_labelselector
branch
from
a73f9c0 to
5951bae
Compare
Signed-off-by: Francesco Pantano <[email protected]>
Not a bug, we just realized during a meeting that it would be better, when we pass the defaultLabelSelector, to match the whole set of labels associated to a deployment or a statefulset, to avoid any scheduling risk for other components matching the same label (because it was a single label). I think this simply switches to the new method, but the behavior is unchanged. |
|
I think we have test coverage here https://github.com/openstack-k8s-operators/placement-operator/blob/main/tests/functional/placementapi_controller_test.go#L499 |
|
@gibizer @mrkisaolamb are you ok to land this patch? I think I need this update due to the hard timeline, wondering if we can approve it |
|
I'm ok with this changes because IMO this is tested but lets wait for @gibizer rsponse |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: bogdando, fmount The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-merge-bot
bot
merged commit 0d4e5e1
into
openstack-k8s-operators:main
No description provided.