Add missing logic for DefaultConfigOverwrite #148
Conversation
| func (r PlacementAPISpec) ValidateCreate(basePath *field.Path) field.ErrorList { | ||
| return r.ValidateDefaultConfigOverwrite(basePath) | ||
| } | ||
|
|
||
| func (r PlacementAPISpec) ValidateUpdate(old PlacementAPISpec, basePath *field.Path) field.ErrorList { | ||
| return r.ValidateDefaultConfigOverwrite(basePath) | ||
| } |
There was a problem hiding this comment.
openstack-operator needs to call this
There was a problem hiding this comment.
Proposed in openstack-k8s-operators/openstack-operator#660
The placement-operator now has validation webhook, so openstack-operator should call it during validation. Depends-On: openstack-k8s-operators/placement-operator#148
There was a problem hiding this comment.
It will be nice if we also clean comments about DefaultConfigOverwrite in https://github.com/openstack-k8s-operators/placement-operator/blob/main/controllers/placementapi_controller.go#L1177
We only want to support the policy.yaml file passthrough for PlacementAPI The kolla config files are modified to move the supported files in place. Implements: OSPRH-2503
gibizer
force-pushed
the
default-config-overwrite
branch
from
a7e7d12 to
21d9e5b
Compare
Done. |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: gibizer, mrkisaolamb The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/test placement-operator-build-deploy-kuttl infra operator failed to start |
openshift-merge-bot
bot
merged commit 533e51d
into
openstack-k8s-operators:main
The placement-operator now has validation webhook, so openstack-operator should call it during validation. Depends-On: openstack-k8s-operators/placement-operator#148
The placement-operator now has validation webhook, so openstack-operator should call it during validation. Depends-On: openstack-k8s-operators/placement-operator#148
We only want to support the policy.yaml file passthrough for PlacementAPI
The kolla config files are modified to move the supported files in place.
Implements: OSPRH-2503