Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drop Debug fields #143

Merged

Conversation

gibizer
Copy link
Collaborator

@gibizer gibizer commented Feb 2, 2024

These fields were redundant. Crashing pods can be debugged via oc debug.

Implements: OSPRH-4290

@gibizer gibizer requested a review from mrkisaolamb February 2, 2024 10:50
@openshift-ci openshift-ci bot requested a review from lewisdenny February 2, 2024 10:50
@openshift-ci openshift-ci bot added the approved label Feb 2, 2024
These fields were redundant. Crashing pods can be debugged via oc debug.

Implements: OSPRH-4290
@gibizer
Copy link
Collaborator Author

gibizer commented Feb 2, 2024

missed the kuttl asserts, fixed now.

Copy link
Contributor

@stuggi stuggi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

Copy link
Contributor

openshift-ci bot commented Feb 2, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: gibizer, stuggi

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-bot openshift-merge-bot bot merged commit e674727 into openstack-k8s-operators:main Feb 2, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants