Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test variable evaluation via cqf expressions #3060

Closed
2 of 3 tasks
ageryck opened this issue Feb 12, 2024 · 3 comments · Fixed by #3200
Closed
2 of 3 tasks

Test variable evaluation via cqf expressions #3060

ageryck opened this issue Feb 12, 2024 · 3 comments · Fixed by #3200
Assignees

Comments

@ageryck
Copy link
Contributor

ageryck commented Feb 12, 2024

Describe the feature request.
Allow the SDC to evaluate variables passed with definite values to be evaluated via cqf expression. An example will be testing a minDate value of a static date provided to validate the datepicker widget.

Additional context
Refer to these two tickets
google/android-fhir#2292
google/android-fhir#1759

And the Implementing PR - google/android-fhir#2326

Acceptance criteria

  • Ability to set a minDate on the date picker and use it for widget validation
  • Ability to use a static date such as patient dob as a minDate
  • Documentation on feature use

Implementation plan (For Engineers)
The plan for implementing the solution e.g. via a description or a check list for the various ordered tasks that will need to be completed.
_i.e. Describe how you intend to solve the problem

Demo

Image of when date min value is today - 6 days and max date is today Image of when min date is birthdate and max date is today Image of when max date is today five days beyond
minvaluedatepicker pdobmindate
maxdate_5days
@brandyodhiambo
Copy link
Contributor

@ndegwamartin and @ageryck have tested the first two cases when the minimum date is set to the patient's birthdate and when it is set to a given date. the date picker restricts dates to be picked according to the values respectively you can see the images appended above.

@ageryck
Copy link
Contributor Author

ageryck commented Apr 12, 2024

@brandy-kay the first screenshot looks okay however it is not visible on the second kindly confirm it is restricted based on the patient birthdate queried through an expression and equally limits the max value as set. If yes then you can proceed to add some documentation about this.

@brandyodhiambo
Copy link
Contributor

sure @ageryck let me test it futher

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants