Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prevent display_name conflicts in oss-directory #629

Closed
ryscheng opened this issue Jan 17, 2025 · 2 comments
Closed

Prevent display_name conflicts in oss-directory #629

ryscheng opened this issue Jan 17, 2025 · 2 comments

Comments

@ryscheng
Copy link
Member

It's been suggested that we prevent multiple projects to claim the same display_name.

I've already written the validation logic to prevent this.
All you need to do is go here and uncomment line 118
https://github.com/opensource-observer/oss-directory/blob/main/src/actions/validate.ts#L118

Then run pnpm validate to see which files have conflicting names.
This issue just embodies the manual work to help fix existing conflicts in our data set so that we can enable this validation in the future

@ccerv1
Copy link
Member

ccerv1 commented Jan 17, 2025

Worked!

I did some script based de-duping and then found the following remaining dupes:

{
  "Ren": [
    "/Users/cerv1-air/GitHub/oss-directory/data/projects/r/renprotocol.yaml",
    "/Users/cerv1-air/GitHub/oss-directory/data/projects/r/ren.yaml"
  ],
  "Reclaim Protocol": [
    "/Users/cerv1-air/GitHub/oss-directory/data/projects/r/reclaimprotocol.yaml",
    "/Users/cerv1-air/GitHub/oss-directory/data/projects/r/reclaim-protocol.yaml"
  ],
  "Polymarket": [
    "/Users/cerv1-air/GitHub/oss-directory/data/projects/t/tokenunion.yaml",
    "/Users/cerv1-air/GitHub/oss-directory/data/projects/p/polymarket.yaml"
  ],
  "Zunami Protocol": [
    "/Users/cerv1-air/GitHub/oss-directory/data/projects/t/therafoundationglobal.yaml",
    "/Users/cerv1-air/GitHub/oss-directory/data/projects/s/studentcointeam.yaml",
    "/Users/cerv1-air/GitHub/oss-directory/data/projects/o/omega8888.yaml",
    "/Users/cerv1-air/GitHub/oss-directory/data/projects/f/fortmatic.yaml",
    "/Users/cerv1-air/GitHub/oss-directory/data/projects/d/databrokerglobal.yaml"
  ],
  "TalentLayer": [
    "/Users/cerv1-air/GitHub/oss-directory/data/projects/t/talentlayer.yaml",
    "/Users/cerv1-air/GitHub/oss-directory/data/projects/t/talentlayer-labs.yaml"
  ],
  "Ponder": [
    "/Users/cerv1-air/GitHub/oss-directory/data/projects/p/ponder-surveys.yaml",
    "/Users/cerv1-air/GitHub/oss-directory/data/projects/p/ponder-sh.yaml"
  ],
  "Astar Network": [
    "/Users/cerv1-air/GitHub/oss-directory/data/projects/p/plasmnetwork.yaml",
    "/Users/cerv1-air/GitHub/oss-directory/data/projects/a/astarnetwork.yaml"
  ],
  "Kotani Pay": [
    "/Users/cerv1-air/GitHub/oss-directory/data/projects/k/kotanipay.yaml",
    "/Users/cerv1-air/GitHub/oss-directory/data/projects/k/kotani-pay.yaml"
  ],
  "Polygon": [
    "/Users/cerv1-air/GitHub/oss-directory/data/projects/m/maticnetwork.yaml",
    "/Users/cerv1-air/GitHub/oss-directory/data/projects/0/0xpolygon.yaml"
  ],
  "Manifold": [
    "/Users/cerv1-air/GitHub/oss-directory/data/projects/m/manifoldco.yaml",
    "/Users/cerv1-air/GitHub/oss-directory/data/projects/m/manifold.yaml"
  ],
  "FindTruman": [
    "/Users/cerv1-air/GitHub/oss-directory/data/projects/f/findtruman.yaml",
    "/Users/cerv1-air/GitHub/oss-directory/data/projects/f/findtruman-official.yaml"
  ],
  "Doodles": [
    "/Users/cerv1-air/GitHub/oss-directory/data/projects/d/doodles.yaml",
    "/Users/cerv1-air/GitHub/oss-directory/data/projects/d/doodles-app.yaml"
  ],
  "Dharma": [
    "/Users/cerv1-air/GitHub/oss-directory/data/projects/d/dharmaprotocol.yaml",
    "/Users/cerv1-air/GitHub/oss-directory/data/projects/d/dharma-eng.yaml"
  ],
  "Decent DAO": [
    "/Users/cerv1-air/GitHub/oss-directory/data/projects/d/decentdao.yaml",
    "/Users/cerv1-air/GitHub/oss-directory/data/projects/d/decent-dao.yaml"
  ],
  "The Graph": [
    "/Users/cerv1-air/GitHub/oss-directory/data/projects/g/graphitetools.yaml",
    "/Users/cerv1-air/GitHub/oss-directory/data/projects/g/graph-protocol.yaml"
  ],
  "Bibliotheca DAO": [
    "/Users/cerv1-air/GitHub/oss-directory/data/projects/b/bibliothecaforadventurers.yaml",
    "/Users/cerv1-air/GitHub/oss-directory/data/projects/b/bibliothecadao.yaml"
  ],
  "Aave": [
    "/Users/cerv1-air/GitHub/oss-directory/data/projects/a/aave.yaml",
    "/Users/cerv1-air/GitHub/oss-directory/data/projects/a/aave-dao.yaml"
  ]
}

@ccerv1
Copy link
Member

ccerv1 commented Jan 17, 2025

#632

@ccerv1 ccerv1 closed this as completed Jan 17, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants