-
Notifications
You must be signed in to change notification settings - Fork 4.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature Request: Router should support setting various tls-related headers #9728
Comments
@pecameron we (the larger networking team) should talk about whether we want to support this as a core part of the route object. But for the moment, can you point at the docs you wrote to replace the router template, and indicate how you could use route annotations to accomplish this change. It would be good to use this as an example in the docs too, because it pulls the template replacement work together with custom route annotations that are defined (with validation rules) in the router. @JacobTanenbaum can point you at the annotation stuff in templates. |
You could do some of this today by adding a configmap with a replacement router template: The Route annotations are available in 3.3. pr9810 shows ways of using annotations. |
It's nice to not have to rebuild the image for a different template (btw @pecameron: it still says that in a few places (stick tables) in the documentation, is that correct?), but I'd argue that setting these headers is important enough to include in the official image. |
Issues go stale after 90d of inactivity. /lifecycle stale |
Stale issues rot after 30d of inactivity. Mark the issue as fresh by commenting If this issue is safe to close now please do so with /lifecycle rotten |
Rotten issues close after 30d of inactivity. Reopen the issue by commenting /close |
It would be great, if the router could set some headers that structurally belong to the route, not the service/pod that is exposed. E.g.
Strict-Transport-Security
, orPublic-Key-Pins
.The text was updated successfully, but these errors were encountered: