Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature Request: Router should support setting various tls-related headers #9728

Closed
ibotty opened this issue Jul 7, 2016 · 6 comments
Closed
Assignees
Labels
component/routing lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. priority/P3

Comments

@ibotty
Copy link
Contributor

ibotty commented Jul 7, 2016

It would be great, if the router could set some headers that structurally belong to the route, not the service/pod that is exposed. E.g. Strict-Transport-Security, or Public-Key-Pins.

@knobunc
Copy link
Contributor

knobunc commented Jul 8, 2016

@pecameron we (the larger networking team) should talk about whether we want to support this as a core part of the route object. But for the moment, can you point at the docs you wrote to replace the router template, and indicate how you could use route annotations to accomplish this change. It would be good to use this as an example in the docs too, because it pulls the template replacement work together with custom route annotations that are defined (with validation rules) in the router. @JacobTanenbaum can point you at the annotation stuff in templates.

@pecameron
Copy link
Contributor

You could do some of this today by adding a configmap with a replacement router template:
https://github.com/openshift/openshift-docs/blob/master/install_config/install/deploy_router.adoc#using-configmap-replace-template

The Route annotations are available in 3.3.

pr9810 shows ways of using annotations.

@ibotty
Copy link
Contributor Author

ibotty commented Jul 27, 2016

It's nice to not have to rebuild the image for a different template (btw @pecameron: it still says that in a few places (stick tables) in the documentation, is that correct?), but I'd argue that setting these headers is important enough to include in the official image.

@openshift-bot
Copy link
Contributor

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.
If this issue is safe to close now please do so with /close.

/lifecycle stale

@openshift-ci-robot openshift-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Feb 6, 2018
@openshift-bot
Copy link
Contributor

Stale issues rot after 30d of inactivity.

Mark the issue as fresh by commenting /remove-lifecycle rotten.
Rotten issues close after an additional 30d of inactivity.
Exclude this issue from closing by commenting /lifecycle frozen.

If this issue is safe to close now please do so with /close.

/lifecycle rotten
/remove-lifecycle stale

@openshift-ci-robot openshift-ci-robot added lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. and removed lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. labels Mar 9, 2018
@openshift-bot
Copy link
Contributor

Rotten issues close after 30d of inactivity.

Reopen the issue by commenting /reopen.
Mark the issue as fresh by commenting /remove-lifecycle rotten.
Exclude this issue from closing again by commenting /lifecycle frozen.

/close

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component/routing lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. priority/P3
Projects
None yet
Development

No branches or pull requests

6 participants