Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

oadm manage-node --evacuate doesn't know about replicasets or daemonsets #11193

Closed
liggitt opened this issue Oct 3, 2016 · 3 comments
Closed

Comments

@liggitt
Copy link
Contributor

liggitt commented Oct 3, 2016

oadm manage-node --evacuate avoids deleting "unmanaged" pods that will not be automatically recreated, but does not pay attention to pods managed by replicasets or daemonsets.

If such pods exist, they get lumped in with one-off pods and require --force to delete.

@mfojtik
Copy link
Contributor

mfojtik commented Oct 10, 2016

@Kargakis i think for making this work, we need to have ownership reference, right?

@0xmichalis
Copy link
Contributor

For manage-node to work we just need to list all replica sets and daemon sets, and use their selectors to filter out pods. Eventually, we should switch to owner references but it's not required for this to be fixed.

@mfojtik
Copy link
Contributor

mfojtik commented Oct 10, 2016

@Kargakis ok

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants