Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Admin] Revisit and update branch protection rules #1387

Closed
peternied opened this issue Mar 22, 2023 · 6 comments
Closed

[Admin] Revisit and update branch protection rules #1387

peternied opened this issue Mar 22, 2023 · 6 comments
Labels

Comments

@peternied
Copy link
Member

After reviewing our many legacy branches, the protection rules are not setup correctly, such as the following pull request on 2.1

image

As there are outstanding pull requests in nearly all branches, make sure the rules are updated and the correct workflow checks are required for changes to be merged.

@stephen-crawford
Copy link
Contributor

[Triage] The maintainers of the Security repository, discussed the topic and came to a general opinion on how to handle the maintenance of deprecated branches. These details will be consolidated and described below before the issue is closed.

@peternied
Copy link
Member Author

@scrawfor99 was that conversation captured / who will provide the updates?

@stephen-crawford
Copy link
Contributor

Hi @peternied, I had thought you had some notes on the topic from last week. Judging by your comment this is not the case...

@peternied
Copy link
Member Author

OK - thanks, double checking. Basically there are a couple of branches that cannot merge because of the misalignment. I'll be addressing this

@peternied peternied removed their assignment May 5, 2023
@peternied
Copy link
Member Author

This isn't actively being worked on as there are no blocked changes at this time, if this comes back up we can re-prioritize this work

@davidlago
Copy link

Closing for now, will reopen when/if it makes sense.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants