Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BUG] "Get started" image is not adaptive to the browser window size. #1386

Closed
nurSaadat opened this issue Mar 22, 2023 · 3 comments · Fixed by #1396
Closed

[BUG] "Get started" image is not adaptive to the browser window size. #1386

nurSaadat opened this issue Mar 22, 2023 · 3 comments · Fixed by #1396
Labels
bug Something isn't working CCI College Contributor Initiative good first issue Good for newcomers triaged

Comments

@nurSaadat
Copy link
Contributor

What is the bug?
The image goes out of the text area when the browser window is minimized.

How can one reproduce the bug?
Steps to reproduce the behavior:

  1. Go to Security -> Get Started
  2. Minimize the browser window

What is the expected behavior?
The image is scaled down to match the browser window size or goes out of the range gracefully.

What is your host/environment?

  • OS: Ubuntu
  • Version: 18.04
  • Browser: Firefox
  • Browser version: 111

image
image
@nurSaadat nurSaadat added bug Something isn't working untriaged labels Mar 22, 2023
@stephen-crawford stephen-crawford added good first issue Good for newcomers triaged CCI College Contributor Initiative and removed untriaged labels Mar 27, 2023
@stephen-crawford
Copy link
Contributor

[Triage] Hi @nurSaadat, thank you for taking the time to file this issue. This seems like a great option for a good first issue, so I am tagging it as such. Any PRs to fix this issue would be happily reviewed.

@curq curq mentioned this issue Apr 6, 2023
Merged
3 tasks
@curq
Copy link
Contributor

curq commented Apr 6, 2023

Hi @scrawfor99, I made a fix, could you please review my PR?

@stephen-crawford
Copy link
Contributor

HI @curq, I will take a look now!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working CCI College Contributor Initiative good first issue Good for newcomers triaged
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix "Get started" image is not adaptive to the browser window size. curq/security-dashboards-plugin
3 participants
@nurSaadat @stephen-crawford @curq