Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEATURE] Return HTTP Status from Extensions #112

Closed
dbwiddis opened this issue Aug 29, 2022 · 0 comments · Fixed by #114
Closed

[FEATURE] Return HTTP Status from Extensions #112

dbwiddis opened this issue Aug 29, 2022 · 0 comments · Fixed by #114
Assignees
Labels
enhancement New feature or request good first issue Good for newcomers

Comments

@dbwiddis
Copy link
Member

Is your feature request related to a problem?

As part of #64, OS #4282 established a basic way for extensions to respond to REST requests with a String.

To expand functionality, the return value from extensions should include the HTTP status (RestStatus enum) along with a String.

What solution would you like?

The ideal return type would be BytesRestResponse but this is not configured to be passed over Transport, so a new ExtensionRestResponse object should be created.

What alternatives have you considered?

Adding the enum value at the beginning of the string with a delimiter. This would work but it's a hack and we should do it right!

Do you have any additional context?

See first comment at #109.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant