Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEATURE] Alllow overriding the aws service identifier in AwsSigv4Signer #330

Closed
bwg opened this issue Nov 16, 2022 · 2 comments
Closed

Comments

@bwg
Copy link
Contributor

bwg commented Nov 16, 2022

Is your feature request related to a problem?

Currently the service identifier is hard coded to es with no way to override.

https://github.com/opensearch-project/opensearch-js/blob/2.1/lib/aws/AwsSigv4Signer.js#L73

What solution would you like?

Allow overriding the default with a user provided value from opts

request.service = opts.service || 'es';

What alternatives have you considered?

rolling our own signing functionality

@wbeckler
Copy link

This makes sense. Feel free to contribute a PR.

@dblock
Copy link
Member

dblock commented Jan 3, 2023

Closing via #333

@dblock dblock closed this as completed Jan 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants