Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEATURE] Release v. Next #303

Closed
dblock opened this issue Sep 29, 2022 · 6 comments
Closed

[FEATURE] Release v. Next #303

dblock opened this issue Sep 29, 2022 · 6 comments

Comments

@dblock
Copy link
Member

dblock commented Sep 29, 2022

Is your feature request related to a problem?

Coming from #187 (comment).

What solution would you like?

Release v. Next.

Do you have any additional context?

Please add your +1 if you need a release.

@dragosmc
Copy link

I see the documentation has been updated with examples containing functionality that wasn't released yet (namely the AWS Sigv4 signer) - I'd have thought that everything that's on "main" is released. Would it make more sense to use a different branching strategy to avoid such issues in the future?

@dblock
Copy link
Member Author

dblock commented Sep 29, 2022

@dragosmc Example? Link? That's really an issue for the documentation, you should open one saying something was documented that wasn't released. I'd expect extreme clarity on http://opensearch.org/ about what version's documentation one is reading.

@dragosmc
Copy link

I don't know if it's visible on the opensearch.org website, but I came here looking for how to do sigv4 and stumbled across this page https://github.com/opensearch-project/opensearch-js/blob/main/USER_GUIDE.md#using-aws-v2-sdk that's referenced from the readme on "main" branch.

@dblock
Copy link
Member Author

dblock commented Sep 29, 2022

I don't know if it's visible on the opensearch.org website, but I came here looking for how to do sigv4 and stumbled across this page https://github.com/opensearch-project/opensearch-js/blob/main/USER_GUIDE.md#using-aws-v2-sdk that's referenced from the readme on "main" branch.

That's expected, the documentation on main is for main. We could put something like https://github.com/ruby-grape/grape#stable-release in that doc, feel free to add that!

@harshavamsi
Copy link
Collaborator

harshavamsi commented Oct 4, 2022

Looks like we have consensus to release 2.1.0 with Sigv4 support. Adding a release checklist and linking infra issue.

All CI pass

  • OpenSearch 2.0 is fully supported
  • OpenSearch 1.x is fully supported

Release Process

https://github.com/opensearch-project/opensearch-js/blob/main/RELEASING.md

Post release

@wbeckler
Copy link

@nhtruong Have the above steps been taken and can we close this?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants