Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ignore plugin failure for OpenSearch snapshot artifact(s) #2716

Closed
bbarani opened this issue Oct 10, 2022 · 5 comments
Closed

Ignore plugin failure for OpenSearch snapshot artifact(s) #2716

bbarani opened this issue Oct 10, 2022 · 5 comments
Assignees
Labels
enhancement New Enhancement

Comments

@bbarani
Copy link
Member

bbarani commented Oct 10, 2022

Is your feature request related to a problem? Please describe

Currently the OpenSearch distribution job generates both -min, snapshot artifacts for components and distribution bundle for OpenSearch. The job fails completely and doesn't upload the -min distribution, snapshot artifacts as well when there is an issue with plugin build.

Describe the solution you'd like

Upload -min distribution, snapshot artifacts of successful builds even when there is any issue with plugin builds

Describe alternatives you've considered

No response

Additional context

No response

@bbarani bbarani added enhancement New Enhancement untriaged Issues that have not yet been triaged labels Oct 10, 2022
@bbarani bbarani changed the title Ignore plugin failure for -min distributions Ignore plugin failure for OpenSearch -min snapshot artifact Oct 10, 2022
@dblock
Copy link
Member

dblock commented Oct 11, 2022

I believe the original problem is about the availability of the -SNAPSHOT builds in Maven, more than -min. The -SNAPSHOT build of each component, including OpenSearch, should be uploaded after each component is built and not after all components are built. Other than OpenSearch we have common-utils, job-scheduler, etc., that all publish SNAPSHOTs to maven.

@bbarani
Copy link
Member Author

bbarani commented Oct 11, 2022

@dblock We are looking in to this issue to resolve the dependencies between different components so we can fail the dependent components once the parent component fails but upload other components with successful build to maven. @prudhvigodithi @peterzhuamazon

@bbarani bbarani changed the title Ignore plugin failure for OpenSearch -min snapshot artifact Ignore plugin failure for OpenSearch snapshot artifact(s) Oct 11, 2022
@bbarani bbarani removed the untriaged Issues that have not yet been triaged label Oct 11, 2022
@peterzhuamazon
Copy link
Member

peterzhuamazon commented Oct 11, 2022

As of now at least the min tar is not blocked for uploads, as for plugin in maven if they fail we still need to fix them tho. I think this is ok for now, as plugin owners who uses min tar can still proceed.

@prudhvigodithi prudhvigodithi self-assigned this Oct 12, 2022
@prudhvigodithi
Copy link
Member

prudhvigodithi commented Oct 13, 2022

Since the related PR is merged #2717, can we proceed to close this? and continue to track #441.

@bbarani
Copy link
Member Author

bbarani commented Oct 17, 2022

Closing this issue and the enhancement to skip plugin failures will be tracked in #441.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New Enhancement
Projects
None yet
Development

No branches or pull requests

4 participants