Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove Elastic repo urls from DistributionDownloadPlugin #91

Closed
2 tasks done
setiah opened this issue Feb 12, 2021 · 7 comments
Closed
2 tasks done

Remove Elastic repo urls from DistributionDownloadPlugin #91

setiah opened this issue Feb 12, 2021 · 7 comments

Comments

@setiah
Copy link
Contributor

setiah commented Feb 12, 2021

These URLs are used for setting up download service.

    private static void setupDownloadServiceRepo(Project project) {
        if (project.getRepositories().findByName(DOWNLOAD_REPO_NAME) != null) {
            return;
        }

        //TODO: remove
        addIvyRepo(project, DOWNLOAD_REPO_NAME, "https://artifacts-no-kpi.elastic.co", FAKE_IVY_GROUP);
        addIvyRepo(project, SNAPSHOT_REPO_NAME, "https://snapshots-no-kpi.elastic.co", FAKE_SNAPSHOT_IVY_GROUP);
    }
  • Ivy repository for releases
  • Ivy repository for snapshots
@adnapibar
Copy link
Contributor

This is resolved by #483 - can this be closed?

@harold-wang
Copy link
Contributor

I think we should update addIvyRepo with different endpoint URL for ES and opensearch, right? @saratvemulapalli @adnapibar

@saratvemulapalli
Copy link
Member

Thats true for backwards compatibility tests we need to point to ES as well.

@setiah
Copy link
Contributor Author

setiah commented May 15, 2021

@saratvemulapalli can we close this?

@saratvemulapalli
Copy link
Member

@setiah I do not think so. We have to update 2 URLs.

  1. Ivy repository for Releases. - Done
  2. Ivy repository for Snapshots. - Yet to be done.

I've updated the issue to make it easier to understand whats left.

@dblock
Copy link
Member

dblock commented May 28, 2021

Looking at

addIvyRepo(project, DOWNLOAD_REPO_NAME, "https://artifacts.opensearch.org", FAKE_IVY_GROUP);
I think we're done here. @saratvemulapalli want to confirm and close?

@saratvemulapalli
Copy link
Member

Looking at

addIvyRepo(project, DOWNLOAD_REPO_NAME, "https://artifacts.opensearch.org", FAKE_IVY_GROUP);

I think we're done here. @saratvemulapalli want to confirm and close?

We can definitely close this one as @peterzhuamazon opened up another issue to track snapshot repositories.
#769

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants