Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Concurrent Segment Search] Add support for profile option with concurrent aggregation #7354

Closed
sohami opened this issue May 2, 2023 · 3 comments
Closed

[Concurrent Segment Search] Add support for profile option with concurrent aggregation #7354

sohami opened this issue May 2, 2023 · 3 comments
Assignees
@ticheng-aws
Labels
distributed framework enhancement Enhancement or improvement to existing feature or request v2.10.0

Comments

@sohami
Copy link
Collaborator

sohami commented May 2, 2023 •
edited
Loading

Placeholder issue to support collecting profile stats with concurrent aggregation flow (both for global and non-global aggregation). This will be dependent on #7353.

Expected behavior
Profile stats with different relevant information similar to sequential flow should be available. For example: with concurrent model, we can have some stats like max/avg/min latency and the slice counts.
@sohami sohami added bug Something isn't working untriaged labels May 2, 2023
@tlfeng tlfeng added the Search Search query, autocomplete ...etc label May 2, 2023
@anasalkouz anasalkouz removed the bug Something isn't working label May 2, 2023
@anasalkouz anasalkouz added enhancement Enhancement or improvement to existing feature or request and removed untriaged labels May 2, 2023
@macohen macohen removed the Search Search query, autocomplete ...etc label May 15, 2023
@ticheng-aws
Copy link
Contributor

Taking a look.

@anasalkouz anasalkouz moved this to In Progress in Concurrent Search Jun 1, 2023
This was referenced Jun 29, 2023
Closed
Closed
Closed
@ticheng-aws
Copy link
Contributor

Subtasks created as below:

  1. [Concurrent Segment Search] Add support for query profiler with concurrent aggregation #8330
  2. [Concurrent Segment Search] Add support for aggregation profiler with concurrent aggregation #8331
  3. [Concurrent Segment Search] Add support for CollectorManager wrapping with profiling with concurrent aggregation #8332

@ticheng-aws
Copy link
Contributor

PR for supporting aggregation profiler: #8801

This was referenced Aug 12, 2023
Merged
Merged
Merged
@reta reta added the v2.10.0 label Aug 15, 2023
@reta reta closed this as completed Aug 15, 2023
@github-project-automation github-project-automation bot moved this from In Progress to Done in Concurrent Search Aug 15, 2023
@ticheng-aws ticheng-aws mentioned this issue Sep 6, 2023
Closed
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ticheng-aws ticheng-aws

Labels
distributed framework enhancement Enhancement or improvement to existing feature or request v2.10.0
Projects
Concurrent Search
Status: Done
Milestone
No milestone
Development

No branches or pull requests
6 participants
@macohen @reta @sohami @anasalkouz @ticheng-aws @tlfeng