Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BUG] EnginePlugin always requires user to implement getEngineFactory #2418

Closed
jmazanec15 opened this issue Mar 9, 2022 · 1 comment
Closed

[BUG] EnginePlugin always requires user to implement getEngineFactory #2418

jmazanec15 opened this issue Mar 9, 2022 · 1 comment
Labels
bug Something isn't working untriaged

Comments

@jmazanec15
Copy link
Member

Describe the bug
EnginePlugin interface requires plugins to implement getEngineFactory. However, when a user just wants to implement getCustomCodecServiceFactory, it requires them to implement this method and return Optional.empty().

To Reproduce
Implement EnginePlugin.

Expected behavior
getEngineFactory to default to empty.

I can submit a fix for this.
@jmazanec15 jmazanec15 added bug Something isn't working untriaged labels Mar 9, 2022
@jmazanec15 jmazanec15 mentioned this issue Mar 9, 2022
Merged
1 task
@jmazanec15
Copy link
Member Author

For ref, here is example of problem.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working untriaged
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@jmazanec15