Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[RW Separation] Honor allocation awareness attributes #16987

Open
Tracked by #15306
mch2 opened this issue Jan 9, 2025 · 3 comments
Open
Tracked by #15306

[RW Separation] Honor allocation awareness attributes #16987

mch2 opened this issue Jan 9, 2025 · 3 comments
Assignees

Comments

@mch2
Copy link
Member

mch2 commented Jan 9, 2025

Today all shards are considered equally by AwarenessAllocationDecider. With search only replicas being primary ineligible, this will leave an imbalance of write or search availability across awareness attributes. To fix this we need to apply the alloc decision to both writer eligible and search only shard groups independently, while also taking into account nodes marked specifically for search with the cluster.routing.allocation.search.replica.dedicated.include setting introduced to allocate search replicas to set of nodes.

@vinaykpud
Copy link
Contributor

Hi @mch2 , Could you assign this issue to me?

@vinaykpud
Copy link
Contributor

vinaykpud commented Feb 10, 2025

Initial commit main...vinaykpud:OpenSearch:rw/search-replica-allocation-awareness

This commit has been added solely for my initial testing. It contains many duplicates that can be optimized. The existing code is highly unreadable.

Changes looks good with the initial shard assignment, works as expected. I went ahead and tested for the zone failure use cases. I found some issues related to the allocation decision(depending on the number of replica and search replica) and shard relocation. I will add the details bellow.

@vinaykpud
Copy link
Contributor

In Addition to this we(Allocator) need to consider allocating replicas and search replicas separately

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Todo
Development

No branches or pull requests

2 participants