Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Remote Cluster State] Refactor BlobStoreformat classess #14117

Open
soosinha opened this issue Jun 10, 2024 · 1 comment
Open

[Remote Cluster State] Refactor BlobStoreformat classess #14117

soosinha opened this issue Jun 10, 2024 · 1 comment
Labels
Cluster Manager ClusterManager:RemoteState enhancement Enhancement or improvement to existing feature or request

Comments

@soosinha
Copy link
Member

soosinha commented Jun 10, 2024

Is your feature request related to a problem? Please describe

There are 2 classes (ChecksumBlobStoreFormat and BaseBlobStoreFormat) which have the logic for serde of XContent objects. For serde of Writable objects, a new class ChecksumWritableBlobStoreForamt has been created. Some methods like serialize and deserialize have duplicate logic in these classes. Also since the BaseBlobStoreFormat is applicable for XContent objects, it is difficult to extend this logic for other objects.

Describe the solution you'd like

Create a interface which provides generic methods to serde of different types of objects. The common logic will be to added header and footer with checksum.

Related component

Cluster Manager

Describe alternatives you've considered

No response

Additional context

No response

@rwali-aws
Copy link

[Triage - attendees 1 2 3 [4]https://github.com/akolarkunnu/ [5]https://github.com/lukas-vlcek/ [6]https://github.com/shiv0408/]

Thanks for filing this issue @soosinha . Can you please update the issue to expand a bit on "Some code has been duplicated across classes" and on the proposal around what common logic is proposed to be moved?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Cluster Manager ClusterManager:RemoteState enhancement Enhancement or improvement to existing feature or request
Projects
Status: Now(This Quarter)
Development

No branches or pull requests

2 participants