Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add 104 Addresses to existing DOI/DAI (Support Inverted Boolean) #789

Closed
dlabordus opened this issue May 30, 2022 · 2 comments
Closed

Add 104 Addresses to existing DOI/DAI (Support Inverted Boolean) #789

dlabordus opened this issue May 30, 2022 · 2 comments
Assignees
Labels

Comments

@dlabordus
Copy link
Contributor

dlabordus commented May 30, 2022

Is your feature request related to a problem? Please describe.
As a 104 Engineer I want to add 2 Address Elements to a existing DOI/DAI which don't have Address Element yet and are allowed to have inverted Address Elements.
If it's allowed by the configuration the Engineer get's the option in the PrepareAddressWizard to indicate if inverted Address Elements are needed. If the Engineer Inverted Address Elements need to be create 2 Address Elements are added, on normal one, and on Address Element with an attribute 'inverted' set to 'true'.

Describe the solution you'd like
Extend the existing logic to support the new CDC types from issue #698.
The configuration in cdc.ts need to be extends with a optional boolean 'inverted' to indicate if inverted is allowed for a specific TI/Filter combination.
In the PrepareAddressWizard two new indicators are added (monitor and control) to let the Engineer choose if Inverted Address Elements should be created. Default valu eis 'false'. If the Engineer indicates this during creating of the Address Elements this indicator and if it's allowed are used to create the Address Elements.
If the indicators are enabled depend on the configuration, if one of the TI's in Monitor/Control indicates Inverted is allowed, the indicator is enabled.

Additional information
It would be nicer if the Engineer first selects the TI, if multiple are allowed, but this means a lot of logic and a specific Wizard for choosing the Inverted. So for now enable the indicator if it's allowed for one of the TI's and check the configuration when adding the Address Element, ignore the indicator of the screen if for the chosen TI it isn't allowed.

@dlabordus dlabordus added the Kind: Enhancement New Request label May 30, 2022
@dlabordus
Copy link
Contributor Author

@Sander3003, we need to define when inverted is needed?

@Sander3003
Copy link
Member

I don't know;

@dlabordus dlabordus self-assigned this Jun 2, 2022
@dlabordus dlabordus added this to the Sprint 2022-06-13 milestone Jun 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants