Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update 3.2 migration recipe to use hibernate 6.3 #514

Closed
mikomatic opened this issue Apr 14, 2024 · 2 comments
Closed

Update 3.2 migration recipe to use hibernate 6.3 #514

mikomatic opened this issue Apr 14, 2024 · 2 comments
Assignees
Labels
enhancement New feature or request

Comments

@mikomatic
Copy link

mikomatic commented Apr 14, 2024

What problem are you trying to solve?

Spring Boot 3.2 updates to Hibernate 6.3 (see release notes ).

Following openrewrite/rewrite-hibernate#23, the org.openrewrite.java.spring.boot3.UpgradeSpringBoot_3_2 recipe could leverage the new org.openrewrite.hibernate.MigrateToHibernate63 migration

Describe the solution you'd like

In the same fashion that the org.openrewrite.java.spring.boot3.UpgradeSpringBoot_3_1 depends on org.openrewrite.hibernate.MigrateToHibernate62, we could add org.openrewrite.hibernate.MigrateToHibernate63 to the org.openrewrite.java.spring.boot3.UpgradeSpringBoot_3_2 recipe

Have you considered any alternatives or workarounds?

n/a

Additional context

This new migration mostly brings migration of the hypersistence-utils dependency to compatible version of hibernate.

Are you interested in contributing this feature to OpenRewrite?

Yes i could do a PR if that is ok with you. The only question I would have is about testing. Since it's only a recipe update - adding a new depending recipe - and the new recipe is already tested in the corresponding repo, I don't know if I should add a specific test suite

@mikomatic mikomatic added the enhancement New feature or request label Apr 14, 2024
@timtebeek
Copy link
Contributor

Thanks a lot for the hint to follow through here @mikomatic ; I've gone ahead and made the required changes as it seemed silly to ask you to do so when it's just as easy for my to do it directly. Thanks for helping out!

@timtebeek timtebeek self-assigned this Apr 14, 2024
@mikomatic
Copy link
Author

@timtebeek no problem! Thank you :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
Archived in project
Development

No branches or pull requests

2 participants